Reconcile Configuration first when using named Revisions #5547
Conversation
This change fixes a problem where RouteReady will periodically go from Unknown to False and then to True when reconciling a Service that uses the "BYO Revision Name" functionality. If the Route reconciles before a Revision has been created it will report a False status and cause clients watching the status to report failure. Since Revision names can only be referenced before they created when a user brings their own name this change serializes the Configuration reconciliation to occur and stabilize before doing the Route reconciliation. Fixes knative#4173
knative-prow-robot
added
the
size/M
There was a problem hiding this comment.
@dgerd: 0 warnings.
In response to this:
This change fixes a problem where RouteReady will periodically go from
Unknown to False and then to True when reconciling a Service that uses
the "BYO Revision Name" functionality. If the Route reconciles before a
Revision has been created it will report a False status and cause
clients watching the status to report failure. Since Revision names can
only be referenced before they created when a user brings their own name
this change serializes the Configuration reconciliation to occur and
stabilize before doing the Route reconciliation.Fixes #4173
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
area/API
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following is the coverage report on pkg/.
|
|
/assign @vagababov |
This change fixes a problem where RouteReady will periodically go from
Unknown to False and then to True when reconciling a Service that uses
the "BYO Revision Name" functionality. If the Route reconciles before a
Revision has been created it will report a False status and cause
clients watching the status to report failure. Since Revision names can
only be referenced before they created when a user brings their own name
this change serializes the Configuration reconciliation to occur and
stabilize before doing the Route reconciliation.
Fixes #4173