Integrate v1 types #5483

dgerd · 2019-09-11T05:41:06Z

Enable v1 API when v1beta1 is enabled
Add v1 to the set of APIs webhook understands

v1alpha1:

Replace inlined references with v1

v1beta1:

Replaces all but outer shape to prevent drifting duplication. Embed v1
directly into v1beta1.
Move context logic into v1

Release Note

Add v1 API types

knative-prow-robot

@dgerd: 12 warnings.

In response to this:

Enable v1 API when v1beta1 is enabled

Add v1 to the set of APIs webhook understands

v1alpha1:

Replace inlined references with v1

v1beta1:

Replaces all but outer shape to prevent drifting duplication. Embed v1
directly into v1beta1.

Move context logic into v1

Fixes #5246

Release Note
Add v1 API types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2019-09-11T05:41:18Z

pkg/apis/serving/v1alpha1/revision_conversion.go

@@ -97,19 +98,19 @@ func (sink *Revision) ConvertDown(ctx context.Context, obj apis.Convertible) err
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *RevisionTemplateSpec) ConvertDown(ctx context.Context, source v1beta1.RevisionTemplateSpec) error {
+func (sink *RevisionTemplateSpec) ConvertDown(ctx context.Context, source v1.RevisionTemplateSpec) error {


Golint naming: receiver name sink should be consistent with previous receiver name source for RevisionTemplateSpec. More info.

knative-prow-robot · 2019-09-11T05:41:18Z

pkg/apis/serving/v1alpha1/revision_conversion.go

 	sink.ObjectMeta = source.ObjectMeta
 	return sink.Spec.ConvertDown(ctx, source.Spec)
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *RevisionSpec) ConvertDown(ctx context.Context, source v1beta1.RevisionSpec) error {
+func (sink *RevisionSpec) ConvertDown(ctx context.Context, source v1.RevisionSpec) error {


Golint naming: receiver name sink should be consistent with previous receiver name source for RevisionSpec. More info.

knative-prow-robot · 2019-09-11T05:41:18Z

pkg/apis/serving/v1alpha1/revision_conversion.go

 	sink.RevisionSpec = *source.DeepCopy()
 	return nil
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *RevisionStatus) ConvertDown(ctx context.Context, source v1beta1.RevisionStatus) {
+func (sink *RevisionStatus) ConvertDown(ctx context.Context, source v1.RevisionStatus) {


Golint naming: receiver name sink should be consistent with previous receiver name source for RevisionStatus. More info.

knative-prow-robot · 2019-09-11T05:41:19Z

pkg/apis/serving/v1alpha1/service_conversion.go

 	default:
 		return fmt.Errorf("unknown version, got: %T", source)
 	}
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *ServiceSpec) ConvertDown(ctx context.Context, source v1beta1.ServiceSpec) error {
+func (sink *ServiceSpec) ConvertDown(ctx context.Context, source v1.ServiceSpec) error {


Golint naming: receiver name sink should be consistent with previous receiver name source for ServiceSpec. More info.

knative-prow-robot · 2019-09-11T05:41:19Z

pkg/apis/serving/v1alpha1/service_conversion.go

 	sink.RouteSpec.ConvertDown(ctx, source.RouteSpec)
 	return sink.ConfigurationSpec.ConvertDown(ctx, source.ConfigurationSpec)
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *ServiceStatus) ConvertDown(ctx context.Context, source v1beta1.ServiceStatus) error {
+func (sink *ServiceStatus) ConvertDown(ctx context.Context, source v1.ServiceStatus) error {


Golint naming: receiver name sink should be consistent with previous receiver name source for ServiceStatus. More info.

knative-prow-robot · 2019-09-11T05:41:19Z

pkg/apis/serving/v1alpha1/route_conversion.go

 	sink.TrafficTarget = source
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *RouteStatus) ConvertDown(ctx context.Context, source v1beta1.RouteStatus) {
+func (sink *RouteStatus) ConvertDown(ctx context.Context, source v1.RouteStatus) {


Golint naming: receiver name sink should be consistent with previous receiver name source for RouteStatus. More info.

knative-prow-robot · 2019-09-11T05:41:19Z

pkg/apis/serving/v1alpha1/route_conversion.go

 	source.Status.ConvertTo(ctx, &sink.Status)

 	sink.RouteStatusFields.ConvertDown(ctx, source.RouteStatusFields)
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *RouteStatusFields) ConvertDown(ctx context.Context, source v1beta1.RouteStatusFields) {
+func (sink *RouteStatusFields) ConvertDown(ctx context.Context, source v1.RouteStatusFields) {


Golint naming: receiver name sink should be consistent with previous receiver name source for RouteStatusFields. More info.

knative-prow-robot · 2019-09-11T05:41:20Z

pkg/apis/serving/v1alpha1/configuration_conversion.go

 	default:
 		return fmt.Errorf("unknown version, got: %T", source)
 	}
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *ConfigurationSpec) ConvertDown(ctx context.Context, source v1beta1.ConfigurationSpec) error {
+func (sink *ConfigurationSpec) ConvertDown(ctx context.Context, source v1.ConfigurationSpec) error {


Golint naming: receiver name sink should be consistent with previous receiver name source for ConfigurationSpec. More info.

knative-prow-robot · 2019-09-11T05:41:20Z

pkg/apis/serving/v1alpha1/configuration_conversion.go

 	sink.Template = &RevisionTemplateSpec{}
 	return sink.Template.ConvertDown(ctx, source.Template)
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *ConfigurationStatus) ConvertDown(ctx context.Context, source v1beta1.ConfigurationStatus) error {
+func (sink *ConfigurationStatus) ConvertDown(ctx context.Context, source v1.ConfigurationStatus) error {


Golint naming: receiver name sink should be consistent with previous receiver name source for ConfigurationStatus. More info.

knative-prow-robot · 2019-09-11T05:41:20Z

pkg/apis/serving/v1alpha1/configuration_conversion.go

 	source.Status.ConvertTo(ctx, &sink.Status)

 	return sink.ConfigurationStatusFields.ConvertDown(ctx, source.ConfigurationStatusFields)
 }

 // ConvertDown helps implement apis.Convertible
-func (sink *ConfigurationStatusFields) ConvertDown(ctx context.Context, source v1beta1.ConfigurationStatusFields) error {
+func (sink *ConfigurationStatusFields) ConvertDown(ctx context.Context, source v1.ConfigurationStatusFields) error {


Golint naming: receiver name sink should be consistent with previous receiver name source for ConfigurationStatusFields. More info.

dgerd · 2019-09-11T06:20:03Z

/test pull-knative-serving-unit-tests

* Enable v1 API when v1beta1 is enabled * Add v1 to the set of APIs webhook understands v1alpha1: * Replace inlined references with v1 v1beta1: * Replaces all but outer shape to prevent drifting duplication. Embed v1 directly into v1beta1. * Move context logic into v1

knative-test-reporter-robot · 2019-09-11T21:19:01Z

The following jobs failed due to test flakiness:

Test name	Triggers	Retries
pull-knative-serving-integration-tests	pull-knative-serving-integration-tests	1/3

Automatically retrying...
/test pull-knative-serving-integration-tests

mattmoor · 2019-09-11T22:16:52Z

pkg/apis/serving/v1alpha1/configuration_conversion_test.go

 					}
+					t.Errorf("ConvertUp() = %v", err)
+				} else if test.badField != "" {
+					t.Errorf("CovnertUp() = %#v, wanted bad field %q", ver,


Suggested change

t.Errorf("CovnertUp() = %#v, wanted bad field %q", ver,

t.Errorf("ConvertUp() = %#v, wanted bad field %q", ver,

knative-metrics-robot · 2019-09-12T00:25:49Z

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/serving/v1alpha1/configuration_conversion.go	90.3%	94.9%	4.5
pkg/apis/serving/v1alpha1/service_conversion.go	97.2%	95.5%	-1.8
pkg/apis/serving/v1beta1/configuration_lifecycle.go	50.0%	100.0%	50.0
pkg/apis/serving/v1beta1/revision_defaults.go	88.6%	100.0%	11.4
pkg/apis/serving/v1beta1/revision_validation.go	95.2%	93.3%	-1.9
pkg/apis/serving/v1beta1/route_lifecycle.go	50.0%	100.0%	50.0
pkg/apis/serving/v1beta1/service_lifecycle.go	50.0%	100.0%	50.0

dgerd · 2019-09-12T00:34:50Z

Tests failures are existing races and don't seem relevant to this change.

/test pull-knative-serving-unit-tests

dgerd · 2019-09-12T01:46:34Z

/assign @mattmoor

mattmoor

/lgtm
/approve

knative-prow-robot · 2019-09-12T16:40:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2019

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 11, 2019

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Sep 11, 2019

knative-prow-robot reviewed Sep 11, 2019

View reviewed changes

knative-prow-robot requested review from dushyanthsc, jonjohnsonjr, markusthoemmes, mattmoor, mdemirhan and tcnghia September 11, 2019 05:41

dgerd force-pushed the v1integ-3 branch from 8fdb1f0 to 53e3ade Compare September 11, 2019 16:52

dgerd force-pushed the v1integ-3 branch from 53e3ade to ae2f395 Compare September 11, 2019 18:10

Bring coverage up

36997d8

Dan Gerdesmeier added 2 commits September 11, 2019 21:19

Add v1 to migration test

253d526

Fix import error

89f2462

dgerd changed the title ~~[WIP] Integrate v1 types~~ Integrate v1 types Sep 11, 2019

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2019

mattmoor reviewed Sep 11, 2019

View reviewed changes

Fix typo

c3d670b

knative-prow-robot assigned mattmoor Sep 12, 2019

mattmoor reviewed Sep 12, 2019

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2019

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2019

knative-prow-robot merged commit b818dce into knative:master Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate v1 types #5483

Integrate v1 types #5483

dgerd commented Sep 11, 2019

knative-prow-robot left a comment

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

knative-prow-robot Sep 11, 2019

dgerd commented Sep 11, 2019

knative-test-reporter-robot commented Sep 11, 2019

mattmoor Sep 11, 2019

knative-metrics-robot commented Sep 12, 2019

dgerd commented Sep 12, 2019

dgerd commented Sep 12, 2019

mattmoor left a comment

knative-prow-robot commented Sep 12, 2019

	t.Errorf("CovnertUp() = %#v, wanted bad field %q", ver,
	t.Errorf("ConvertUp() = %#v, wanted bad field %q", ver,

Integrate v1 types #5483

Integrate v1 types #5483

Conversation

dgerd commented Sep 11, 2019

knative-prow-robot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgerd commented Sep 11, 2019

knative-test-reporter-robot commented Sep 11, 2019

Choose a reason for hiding this comment

knative-metrics-robot commented Sep 12, 2019

dgerd commented Sep 12, 2019

dgerd commented Sep 12, 2019

mattmoor left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Sep 12, 2019