Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make k8schain work with repository-level config #5477

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Make k8schain work with repository-level config #5477

merged 2 commits into from
Sep 11, 2019

Conversation

jonjohnsonjr
Copy link
Contributor

Fixes #4435

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 10, 2019
@jonjohnsonjr
Copy link
Contributor Author

I can't figure out why this pulled in so many extra packages.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Sep 10, 2019
@jonjohnsonjr
Copy link
Contributor Author

/retest

@jonjohnsonjr
Copy link
Contributor Author

I can't figure out why this pulled in so many extra packages.

Figured it out. We use random in one of our tests, which pulls in a lot more stuff now due to google/go-containerregistry#505

@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review September 10, 2019 16:57
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2019
@jonjohnsonjr
Copy link
Contributor Author

/assign @mattmoor

@adrcunha adrcunha requested review from mattmoor and removed request for adrcunha and steuhs September 10, 2019 17:12
mattmoor
mattmoor reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonjohnsonjr, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@knative-prow-robot knative-prow-robot merged commit b2846d8 into knative:master Sep 11, 2019
@dgerd dgerd mentioned this pull request Dec 16, 2019
Merged
@jonjohnsonjr jonjohnsonjr deleted the fix-k8schain branch March 11, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revision: cannot use private registry
4 participants
@jonjohnsonjr @knative-prow-robot @mattmoor @googlebot