Add sleeps to the tests that panic in the logger. #5439
Conversation
knative-prow-robot
added
the
size/S
knative-prow-robot
added
approved
Currently we have no way to knowing when the informers stop. And if that's even possible. So these are bandaids for the tests that are now failing a lot on the prow. I've verified all of them with -race -count=5 setup on my machine, but let's see how they work on Prod. I don't really want to put the sleep in the cancel() since a lot of tests don't need it. Longer term, we need to find a way to find out whether the informer stopped actually doing stuff or do something with logger so that it knows test terminated and does not pass on to t.Logf. /assign mattmoor
vagababov
force-pushed
the
more-sleeps-for-the-babies
branch
from
bb1bf43 to
9d46ba2
Compare
knative-prow-robot
added
size/M
|
The following is the coverage report on pkg/.
|
| ctx, cancel, _, _, reconciler, watcher := newTestSetup(t) | ||
| defer func() { | ||
| cancel() | ||
| time.Sleep(3 * time.Second) |
There was a problem hiding this comment.
I wonder if we should make SetupFakeContextWithCancel(t) return a cancel function with this built in for now.
There was a problem hiding this comment.
I commented on this, since not all the tests suffer from this, making all of them delayed sounds a bit harsh.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following jobs failed due to test flakiness:
Automatically retrying... |
Currently we have no way to knowing when the informers stop. And if that's even possible.
So these are bandaids for the tests that are now failing a lot on the prow.
I've verified all of them with -race -count=5 setup on my machine,
but let's see how they work on Prod.
Longer term, we need to find a way to find out whether the informer stopped actually doing stuff
or do something with logger so that it knows test terminated and does not pass on to t.Logf.
/assign mattmoor