Move validation of autoscaling.knative.dev/metric to RevisionTemplateSpec #5412
Conversation
…to RevisionTemplateSpec
knative-prow-robot
added
the
size/L
| "knative.dev/serving/pkg/apis/serving" | ||
| ) | ||
|
|
||
| func (pa *PodAutoscaler) Validate(ctx context.Context) *apis.FieldError { | ||
| errs := serving.ValidateObjectMetadata(pa.GetObjectMeta()).ViaField("metadata") | ||
| errs = errs.Also(pa.validateMetric()) |
There was a problem hiding this comment.
Not sure if we might still want to keep this around, for backward compatibility for existing services that have already been created before this and had invalid metric annotation.
There was a problem hiding this comment.
Existing services means?
Even if service created that service won't be created successfully
| // Leave other classes of PodAutoscaler alone. | ||
| return nil | ||
| } | ||
| return apis.ErrInvalidValue(metric, MetricAnnotationKey) |
There was a problem hiding this comment.
so this is unreachable now?
There was a problem hiding this comment.
No its not unreachable
When MetricAnnotationKey is invalid for class HPA and KPA it will execute that line
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/retest |
Proposed Changes
autoscaling.knative.dev/metricannotation validation from PodAutoscaler to RevisionTemplateSpecActual:
Create service with Invalid value of
autoscaling.knative.dev/metricannotation gives error message in the revision statusExpected:
service create/update should fail with invalid
autoscaling.knative.dev/metricannotation