Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route cluster-local visibility should take precedence over placeholder Services #5411

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Route cluster-local visibility should take precedence over placeholder Services #5411

merged 1 commit into from
Sep 6, 2019

Conversation

tcnghia
Copy link
Contributor

@tcnghia tcnghia commented Sep 6, 2019 •
edited
Loading

When Route has cluster-local visibility, all sub-Route should use that
and ignore settings on placeholder Services.

Fixes #

Proposed Changes

  • cluster-local visibility on Route will take precedence over placeholder Services' setting.
  • Do not copy visibility setting from Route to placeholder Services, because that would overwrite user settings.

Release Note

Fix a bug in cluster-local Service handling that cause cluster-local visibility setting to be not changeable for ksvc and Route.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 6, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/networking labels Sep 6, 2019
knative-prow-robot
knative-prow-robot reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcnghia: 0 warnings.

In response to this:

When Route has cluster-local visibility, all sub-Route should use that
and ignore settings on placeholder Services.

Fixes #

Proposed Changes

  • cluster-local visibility on Route will take precedence over placeholder Services' setting.
  • Do not copy visibility setting from Route to placeholder Services, because that would overwrite user settings.

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
Route cluster-local visibility should take precedence.
08771f0 
When Route has cluster-local visibility, all sub-Route should use that
and ignore settings on placeholder Services.
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/route/resources/service.go 88.9% 88.5% -0.4

@tcnghia tcnghia changed the title [WIP] Route cluster-local visibility should take precedence over placeholder Services Route cluster-local visibility should take precedence over placeholder Services Sep 6, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2019
@tcnghia
Copy link
Contributor Author

tcnghia commented Sep 6, 2019

/assign @ZhiminXiang

@ZhiminXiang
Copy link

/lgmt
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ZhiminXiang
Copy link

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@knative-prow-robot knative-prow-robot merged commit 4bb3e83 into knative:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@ZhiminXiang ZhiminXiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcnghia @knative-metrics-robot @ZhiminXiang @knative-prow-robot @googlebot