-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPS support for HPA #5312
Add RPS support for HPA #5312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yanweiguo: 0 warnings.
In response to this:
Fixes #5216
Proposed Changes
- Allow HPA to use RPS metric as annotation.
- Add RPS support for HPA.
- The
MetricProvider
change was done in Report RPS for autoscaler metrics #5238.Release Note
Autoscaling using HPA supports requests-per-second as metric.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I presume Integration test comes next? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vagababov, yanweiguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, will add to #5244 as well |
/hold cancel |
/test pull-knative-serving-integration-tests |
The following jobs failed due to test flakiness:
Automatically retrying... |
/lgtm |
/test pull-knative-serving-unit-tests |
Fixes #5216
Proposed Changes
MetricProvider
change was done in Report RPS for autoscaler metrics #5238.Release Note