Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPS support for HPA #5312

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Conversation

yanweiguo
Copy link
Contributor

Fixes #5216

Proposed Changes

Release Note

Autoscaling using HPA supports requests-per-second as metric. 

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 28, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers area/autoscale labels Aug 28, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanweiguo: 0 warnings.

In response to this:

Fixes #5216

Proposed Changes

Release Note

Autoscaling using HPA supports requests-per-second as metric. 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vagababov
Copy link
Contributor

I presume Integration test comes next?
/lgtm
/approve
/hold

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 30, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2019
@yanweiguo
Copy link
Contributor Author

I presume Integration test comes next?
/lgtm
/approve
/hold

Yeah, will add to #5244 as well

@yanweiguo
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2019
@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

@knative-test-reporter-robot

The following jobs failed due to test flakiness:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests
2/3

Automatically retrying...
/test pull-knative-serving-integration-tests

@vagababov
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2019
@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-unit-tests

@knative-prow-robot knative-prow-robot merged commit a01e230 into knative:master Aug 30, 2019
@yanweiguo yanweiguo deleted the rps_for_hpa branch September 11, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autoscaling based on RPS for HPA
5 participants