Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This picks up the changes to how we do global resyncs. #5275

Merged
merged 1 commit into from
Aug 25, 2019
Merged

This picks up the changes to how we do global resyncs. #5275

merged 1 commit into from
Aug 25, 2019

Conversation

mattmoor
Copy link
Member

knative/pkg#597 changed the way we handle
global resyncs to combine the two approaches we use today and add
a jitter to alleviate an issue we were seeing at scale.

@mattmoor
This picks up the changes to how we do global resyncs.
233a3a8 
knative/pkg#597 changed the way we handle
global resyncs to combine the two approaches we use today and add
a jitter to alleviate an issue we were seeing at scale.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 25, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking labels Aug 25, 2019
@mattmoor mattmoor mentioned this pull request Aug 25, 2019
Merged
@vagababov
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/ingress/status.go 85.9% 86.1% 0.3

@knative-test-reporter-robot
Copy link

The following jobs failed due to test flakiness:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests		 2/3

Automatically retrying...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit 508ab0f into knative:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@vagababov vagababov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattmoor @knative-prow-robot @vagababov @knative-metrics-robot @knative-test-reporter-robot @googlebot