Consistent update for ObservedGeneration for ingress: update observed generation -> reconcile -> update status

[taragu]

/lint

Part of #5076

Proposed Changes

• Update ingress ObservedGeneration before reconciling to indicate that we've attempted to reconcile its spec, and marking ingress as not ready if reconciliation fails

Release Note

NONE

/cc @jonjohnsonjr

[knative-prow-robot]

@taragu: 1 warning.

In response to this:

/lint

Part of #5076

Proposed Changes

• Update ingress ObservedGeneration before reconciling to indicate that we've attempted to reconcile its spec, and marking ingress as not ready if reconciliation fails

Release Note

NONE

/cc @jonjohnsonjr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Hi @taragu. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[taragu]

/ok-to-test

[knative-test-reporter-robot]

The following jobs failed due to test flakiness:

Test name	Triggers	Retries
pull-knative-serving-integration-tests	pull-knative-serving-integration-tests	1/3

Automatically retrying...
/test pull-knative-serving-integration-tests

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/networking/v1alpha1/ingress_lifecycle.go	92.3%	92.9%	0.5
pkg/reconciler/route/route.go	83.7%	84.2%	0.5

[taragu]

@vagababov would you please take a look at this when you get a chance?

[vagababov]

Why did we rearrange the events?

[taragu]

@vagababov the main rearrangement in this PR is when to update the observed generation. We want to update it first so that even if an error is encountered, we show that we've attempted to reconcile the spec (number 3 in #5076 (comment) )

[vagababov]

Ah, I see.
/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: taragu, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/networking/OWNERS [vagababov]
• pkg/reconciler/clusteringress/OWNERS [vagababov]
• pkg/reconciler/ingress/OWNERS [vagababov]
• pkg/reconciler/route/OWNERS [vagababov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[taragu]

/test pull-knative-serving-integration-tests