Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default timeout when 0 is specified #5224

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Set default timeout when 0 is specified #5224

merged 3 commits into from
Aug 20, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 20, 2019

Proposed Changes

This patch sets timeoutSeconds to default value when 0 is specified.

Fixes #5221

/lint

Release Note

NONE

@nak3
Set default timeout when 0 is specified
8da64af 
This patch sets timeoutSeconds to default when 0 is specified.

Fixes knative#5221
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers labels Aug 20, 2019
knative-prow-robot
knative-prow-robot reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nak3: 0 warnings.

In response to this:

Proposed Changes

This patch sets timeoutSeconds to default value when 0 is specified.

Fixes #5221

/lint

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor Author

nak3 commented Aug 20, 2019

cc @dgerd

@nak3
Copy link
Contributor Author

nak3 commented Aug 20, 2019

/test pull-knative-serving-build-tests

# knative.dev/serving/test/test_images/pizzaplanetv2
truncated object file: $WORK/b372/_pkg_.a(_go_.o): read $WORK/b372/_pkg_.a: cannot allocate memory

This should not be related to this PR.

vagababov
vagababov reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
in case @dgerd has issues.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2019
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
markusthoemmes
markusthoemmes approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dgerd
Copy link

dgerd commented Aug 20, 2019

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, markusthoemmes, nak3, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@markusthoemmes
Copy link
Contributor

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2019
@knative-prow-robot knative-prow-robot merged commit 4946aa9 into knative:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vagababov vagababov

@markusthoemmes markusthoemmes

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimeoutSeconds: 0 should result in default timeout
6 participants
@nak3 @dgerd @knative-prow-robot @markusthoemmes @vagababov @googlebot