Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component names containing invalid (for Prometheus) characters #4735

Merged

Conversation

JRBANCEL
Copy link
Contributor

Fixes #4716

Proposed Changes

  • Remove -
  • Use single word namespace as recommended

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 12, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/networking labels Jul 12, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JRBANCEL: 0 warnings.

In response to this:

Fixes #4716

Proposed Changes

  • Remove -
  • Use single word namespace as recommended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -24,6 +24,6 @@ import (
)

func main() {
sharedmain.Main("controller-certificate-cert-manager",
sharedmain.Main("certcontroller",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sharedmain.Main("certcontroller",
sharedmain.Main("cert_controller",

same below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://prometheus.io/docs/practices/naming/#metric-names

A metric name should have a (single-word) application prefix relevant to the domain the metric belongs to. The prefix is sometimes referred to as namespace by client libraries. For metrics specific to an application, the prefix is usually the application name itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's supper annoying

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth extracting into a constant with a link to that doc in the doc comment to avoid accidental changes.

@vagababov
Copy link
Contributor

/lgtm
/approve

you'll have to rebase everything for the knative.dev.

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2019
@JRBANCEL JRBANCEL force-pushed the remove-dash-in-component-name branch from 6a105f8 to ddc4a3e Compare July 12, 2019 18:42
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
@JRBANCEL JRBANCEL force-pushed the remove-dash-in-component-name branch from ddc4a3e to 2727217 Compare July 12, 2019 20:39
@JRBANCEL
Copy link
Contributor Author

Rebased. Feel free to re-LGTM 🙏

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Annoying indeed!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JRBANCEL, markusthoemmes, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 38e7557 into knative:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash in controller name cause metrics to be dropped
6 participants