-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix component names containing invalid (for Prometheus) characters #4735
Fix component names containing invalid (for Prometheus) characters #4735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JRBANCEL: 0 warnings.
In response to this:
Fixes #4716
Proposed Changes
- Remove
-
- Use single word namespace as recommended
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@@ -24,6 +24,6 @@ import ( | |||
) | |||
|
|||
func main() { | |||
sharedmain.Main("controller-certificate-cert-manager", | |||
sharedmain.Main("certcontroller", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sharedmain.Main("certcontroller", | |
sharedmain.Main("cert_controller", |
same below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://prometheus.io/docs/practices/naming/#metric-names
A metric name should have a (single-word) application prefix relevant to the domain the metric belongs to. The prefix is sometimes referred to as namespace by client libraries. For metrics specific to an application, the prefix is usually the application name itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's supper annoying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth extracting into a constant with a link to that doc in the doc comment to avoid accidental changes.
/lgtm you'll have to rebase everything for the knative.dev. |
6a105f8
to
ddc4a3e
Compare
ddc4a3e
to
2727217
Compare
Rebased. Feel free to re-LGTM 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Annoying indeed!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JRBANCEL, markusthoemmes, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4716
Proposed Changes
-