Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The configuration for the autoscaler probe. #4456

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

vagababov
Copy link
Contributor

Mirror the one we're using in other places.

/assign @mattmoor

Fixes #4454

mirror the one we're using in other places.

/assign @mattmoor
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 21, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2019
@mattmoor
Copy link
Member

/lgtm
/approve

You will have to /retest when the other change goes in.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@markusthoemmes
Copy link
Contributor

/retest

1 similar comment
@vagababov
Copy link
Contributor Author

/retest

@vagababov
Copy link
Contributor Author

/test pull-knative-serving-integration-tests
/test pull-knative-serving-smoke-tests

🐲

@vagababov
Copy link
Contributor Author

/test pull-knative-serving-integration-tests
/test pull-knative-serving-smoke-tests

@vagababov
Copy link
Contributor Author

/retest

1 similar comment
@mattmoor
Copy link
Member

/retest

@knative-prow-robot knative-prow-robot merged commit 8ce7d73 into knative:master Jun 21, 2019
@vagababov vagababov deleted the autoscaler-probe-2 branch September 2, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaler has no health probe.
5 participants