Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for user set headers #4411

Merged
merged 5 commits into from
Jun 20, 2019
Merged

Add test case for user set headers #4411

merged 5 commits into from
Jun 20, 2019

Conversation

dgerd
Copy link

@dgerd dgerd commented Jun 18, 2019

Make sure that headers supplied by the user on the request are available
within the container.

Fixes #3208

Release Note

Add user set header conformance test

Add test case for user set headers
5fbe7a2 
Make sure that headers supplied by the user on the request are available
within the container.

Fixes knative#3208
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 18, 2019
knative-prow-robot
knative-prow-robot reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgerd: 0 warnings.

In response to this:

Make sure that headers supplied by the user on the request are available
within the container.

Fixes #3208

Release Note

Add user set header conformance test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jun 18, 2019
vagababov
vagababov reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superficial.

vagababov
vagababov reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@dgerd
Copy link
Author

dgerd commented Jun 18, 2019

/test pull-knative-serving-integration-tests

markusthoemmes
markusthoemmes approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
mattmoor
mattmoor reviewed Jun 20, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, markusthoemmes, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@dgerd
Copy link
Author

dgerd commented Jun 20, 2019

/retest

@dgerd
Copy link
Author

dgerd commented Jun 20, 2019

/test pull-knative-serving-smoke-tests

@knative-prow-robot knative-prow-robot merged commit ef6ad93 into knative:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@mattmoor mattmoor mattmoor left review comments

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@grantr grantr Awaiting requested review from grantr

@nbarthwal nbarthwal Awaiting requested review from nbarthwal

Assignees

@vagababov vagababov

@markusthoemmes markusthoemmes

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Conformance test for user set headers
7 participants
@dgerd @knative-prow-robot @vagababov @markusthoemmes @mattmoor @mattmoor-sockpuppet @googlebot