Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate annotations to the route from svc #4363

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Propagate annotations to the route from svc #4363

merged 2 commits into from
Jun 14, 2019

Conversation

vagababov
Copy link
Contributor

Fixes #4087

Proposed Changes

  • propagate annotations to the route
  • update tests

/assign @mattmoor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 14, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2019
@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jun 14, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/service/service.go 87.8% 88.0% 0.2

@dprotaso
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2019
@knative-prow-robot knative-prow-robot merged commit 6c27ba2 into knative:master Jun 14, 2019
@vagababov vagababov deleted the 4087-propagate-route branch September 2, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@dprotaso dprotaso

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconcile annotations from ksvc to Routes
6 participants
@vagababov @knative-prow-robot @knative-metrics-robot @dprotaso @mattmoor @googlebot