Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark IngressNotConfigured on Route when there is no Ingress status #4288

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Mark IngressNotConfigured on Route when there is no Ingress status #4288

merged 3 commits into from
Jun 21, 2019

Conversation

tanzeeb
Copy link
Contributor

@tanzeeb tanzeeb commented Jun 7, 2019 •
edited
Loading

Fixes #4072

Proposed Changes

  • Set the IngressReady condition on Route to Unknown/IngressNotConfigured/Failed to configure ingress for route if the ClusterIngress has no status

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 7, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers area/networking labels Jun 7, 2019
knative-prow-robot
knative-prow-robot reviewed Jun 7, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanzeeb: 1 warning.

In response to this:

Fixes #4072

Proposed Changes

  • Set the IngressReady condition on Route to Unknown/IngressNotConfigured/Failed to configure ingress for route if the ClusterIngress has no status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tanzeeb
Copy link
Contributor Author

tanzeeb commented Jun 7, 2019

/assign @tcnghia

@tanzeeb
Copy link
Contributor Author

tanzeeb commented Jun 7, 2019

/test pull-knative-serving-unit-tests

@tcnghia
Copy link
Contributor

tcnghia commented Jun 7, 2019

/lgtm
/approve

Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Jun 7, 2019

/assign @dgerd

@tanzeeb tanzeeb force-pushed the no-ingress-status branch from d2b3ab0 to c01795f Compare June 13, 2019 21:00
@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features and removed lgtm Indicates that a PR is ready to be merged. labels Jun 13, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Jun 13, 2019

@dgerd can you please help with apis/OWNERS? thanks

@tcnghia
Copy link
Contributor

tcnghia commented Jun 13, 2019

Actually I see that @mattmoor needs to approve.

/assign @mattmoor

vagababov
vagababov reviewed Jun 17, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linter error.

Otherwise looks fine.

mattmoor
mattmoor reviewed Jun 19, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, tanzeeb, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@tanzeeb
Copy link
Contributor Author

tanzeeb commented Jun 19, 2019

/test pull-knative-serving-build-tests
/test pull-knative-serving-upgrade-tests

@greghaynes
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@mattmoor
Copy link
Member

/retest

1 similar comment
@tcnghia
Copy link
Contributor

tcnghia commented Jun 20, 2019

/retest

@tcnghia
Copy link
Contributor

tcnghia commented Jun 20, 2019

/test pull-knative-serving-build-tests
/test pull-knative-serving-integration-tests

@tanzeeb
Copy link
Contributor Author

tanzeeb commented Jun 20, 2019

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit c2a2bd6 into knative:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@greghaynes greghaynes

@tcnghia tcnghia

@mattmoor mattmoor

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route report wrong Status when not getting ClusterIngress Status
8 participants
@tanzeeb @tcnghia @knative-prow-robot @greghaynes @mattmoor @vagababov @googlebot @dgerd