Add probe to upgrade test

[jonjohnsonjr]

Fixes #2786

[knative-prow-robot]

@jonjohnsonjr: 0 warnings.

In response to this:

Fixes #2786

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jonjohnsonjr]

/test pull-knative-serving-upgrade-tests

[jonjohnsonjr]

It's alive!

I0604 17:43:19.962] --- FAIL: TestProbe (392.34s)
I0604 17:43:19.962]     probe_test.go:38: Creating a new Service
I0604 17:43:19.962]     service.go:106: Creating a new Service upgrade-probe.
I0604 17:43:19.967]     util.go:34: resource {<nil> <nil> <*>{&TypeMeta{Kind:,APIVersion:,} &ObjectMeta{Name:upgrade-probe,GenerateName:,Namespace:,SelfLink:,UID:,ResourceVersion:,Generation:0,CreationTimestamp:0001-01-01 00:00:00 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{},Annotations:map[string]string{},OwnerReferences:[],Finalizers:[],ClusterName:,Initializers:nil,} {0 <nil> <nil> <nil> <nil> {0 <nil> <nil> <*>&ObjectMeta{Name:,GenerateName:,Namespace:,SelfLink:,UID:,ResourceVersion:,Generation:0,CreationTimestamp:0001-01-01 00:00:00 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{},Annotations:map[string]string{},OwnerReferences:[],Finalizers:[],ClusterName:,Initializers:nil,}} {0 [{ {   <*>true 100 <nil>}}]}} {{0 <nil>} {<nil>   <nil> <nil>} { }}} <nil>}
I0604 17:43:19.979]     service.go:121: Waiting for Service "upgrade-probe" to transition to Ready.
I0604 17:43:19.983]     service.go:126: Checking to ensure Service Status is populated for Ready service upgrade-probe
I0604 17:43:19.983]     service.go:132: Getting latest objects Created by Service upgrade-probe
I0604 17:43:19.986]     service.go:135: Successfully created Service upgrade-probe
I0604 17:43:19.989]     probe_test.go:44: Starting to probe upgrade-probe.serving-tests.35.238.17.192.xip.io
I0604 17:43:19.992]     prober.go:158: Starting Route prober for route domain upgrade-probe.serving-tests.35.238.17.192.xip.io.
I0604 17:43:19.993]     prober.go:112: "upgrade-probe.serving-tests.35.238.17.192.xip.io" status = 404, want: 200
I0604 17:43:19.994]     prober.go:113: response: status: 404, body: , headers: map[Content-Length:[0] Date:[Tue, 04 Jun 2019 17:36:57 GMT] Location:[http://upgrade-probe.serving-tests.35.238.17.192.xip.io/] Server:[istio-envoy] Zipkin_trace_id:[2a4f9f2fa3afdf8dbaf93ff58978f880]]
I0604 17:43:19.999]     prober.go:112: "upgrade-probe.serving-tests.35.238.17.192.xip.io" status = 404, want: 200
I0604 17:43:20.000]     prober.go:113: response: status: 404, body: , headers: map[Content-Length:[0] Date:[Tue, 04 Jun 2019 17:36:58 GMT] Location:[http://upgrade-probe.serving-tests.35.238.17.192.xip.io/] Server:[istio-envoy] Zipkin_trace_id:[0118a2bfa6870e54661c967919a0e451]]
I0604 17:43:20.000]     prober.go:204: Stopping all probers
I0604 17:43:20.000]     probe_test.go:50: CheckSLO() = SLI for "TestProbe" = 0.994764, wanted >= 1.000000
I0604 17:43:20.000] FAIL
I0604 17:43:20.000] FAIL	github.com/knative/serving/test/upgrade	392.628s
I0604 17:43:20.477] ERROR: Prober failed

[jonjohnsonjr]

/retest

[jonjohnsonjr]

/assign @vagababov

[greghaynes]

Neat! What do you think about either having the test own the pipe completely or at least perform the cleanup? Setting trap's in bash are a bit of a maintenance pain (since they overwrite any existing ones globally) and are a pain to reason about IME, this would get rid of that.

[jonjohnsonjr]

Neat! What do you think about either having the test own the pipe completely or at least perform the cleanup? Setting trap's in bash are a bit of a maintenance pain (since they overwrite any existing ones globally) and are a pain to reason about IME, this would get rid of that.

Great idea

[adrcunha]

This is so cool. :)

[jonjohnsonjr]

This is ready for another look.

[greghaynes]

/lgtm

[adrcunha]

/lgtm

[vagababov]

/lgtm

[vagababov]

/hold
just in case you want to do the flag

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, jonjohnsonjr, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [adrcunha,vagababov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jonjohnsonjr]

/hold cancel

just in case you want to do the flag

Took a stab at it but was thwarted by this and don't care to fix it yet.