Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining deprecated fields from status. #4197

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Remove remaining deprecated fields from status. #4197

merged 1 commit into from
Jun 3, 2019

Conversation

mattmoor
Copy link
Member

With this change, our objects should exist at rest strictly within the v1beta1 subset 🎉

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 31, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/route/reconcile_resources.go 89.5% 85.0% -4.5
pkg/reconciler/route/route.go 92.1% 84.7% -7.4
pkg/reconciler/route/traffic/traffic.go 95.2% 94.2% -1.1
pkg/reconciler/service/service.go 89.5% 87.8% -1.7

@mattmoor
Copy link
Member Author

/retest

@mattmoor mattmoor added this to the Serving 0.7 milestone May 31, 2019
@mattmoor mattmoor force-pushed the less-deprecated-stuff-is-good branch from 47b0388 to bc774c7 Compare May 31, 2019 03:47
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label May 31, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/route/reconcile_resources.go 89.5% 85.0% -4.5
pkg/reconciler/route/route.go 92.1% 84.7% -7.4
pkg/reconciler/route/traffic/traffic.go 95.2% 94.2% -1.1
pkg/reconciler/service/service.go 89.5% 87.8% -1.7

dgerd
dgerd reviewed May 31, 2019
View reviewed changes
pkg/reconciler/route/route.go
@@ -176,7 +176,8 @@ func (c *Reconciler) reconcile(ctx context.Context, r *v1alpha1.Route) error {
Scheme: "http",
Host: host,
}
r.Status.DeprecatedDomain = host
// TODO(mattmoor): Remove completely after 0.7 cuts.
r.Status.DeprecatedDomain = ""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clients should already be updated to read the new fields per M1. Why do we need to preserve this in 0.7?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is forcibly clearing the fields from old resources. We can remove it after 0.7 because 0.7 will have cleared it out of any existing resources.

@mattmoor mattmoor force-pushed the less-deprecated-stuff-is-good branch from bc774c7 to ecc6732 Compare June 2, 2019 21:56
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/route/reconcile_resources.go 89.5% 85.0% -4.5
pkg/reconciler/route/route.go 92.1% 84.7% -7.4
pkg/reconciler/route/traffic/traffic.go 95.2% 94.2% -1.1
pkg/reconciler/service/service.go 89.5% 87.8% -1.7

@mattmoor
Copy link
Member Author

mattmoor commented Jun 3, 2019

/retest

1 similar comment
@mattmoor
Copy link
Member Author

mattmoor commented Jun 3, 2019

/retest

@dgerd
Copy link

dgerd commented Jun 3, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2019
@chaodaiG
Copy link
Contributor

chaodaiG commented Jun 3, 2019

ping tide

@steuhs steuhs merged commit 853f5b5 into knative:master Jun 3, 2019
@mattmoor mattmoor deleted the less-deprecated-stuff-is-good branch June 3, 2019 18:32
This was referenced Jun 8, 2019
Closed
Closed
Closed
joshrider pushed a commit to joshrider/serving that referenced this pull request Jun 10, 2019
@mattmoor @joshrider
Remove remaining deprecated fields from status. (knative#4197)
c19ee6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgerd dgerd dgerd left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
0.7.x
Development

Successfully merging this pull request may close these issues.
7 participants
@mattmoor @knative-metrics-robot @knative-prow-robot @dgerd @chaodaiG @googlebot @steuhs