Output info message when clusteringress's status was updated successfully #4144
Conversation
knative-prow-robot
added
the
size/S
knative-prow-robot
added
the
needs-ok-to-test
|
Hi @nak3. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I think we use just "Reconciled ...". /Ok-to-test |
|
/ok-to-test |
knative-prow-robot
added
ok-to-test
| return err | ||
| } else { | ||
| if _, err = c.updateStatus(ci); err != nil { | ||
| logger.Warnw("Failed to update clusterIngress status", zap.Error(err)) |
There was a problem hiding this comment.
| logger.Warnw("Failed to update clusterIngress status", zap.Error(err)) | |
| logger.Warnw("Failed to update ClusterIngress status", zap.Error(err)) |
…ully When `config-domain` configmap was updated, event log from clusteringress sometimes tells us that `Failed to update status for ClusterIngress`. Although this error would be solved automatically by next reconcile loop, we don't know whether it was solved or not because there are no success log. To improve it, this patch adds success logs when clusteringress was updated successfully.
|
The following is the coverage report on pkg/.
|
|
Thank you @vagababov Updated. And squashed the commits as it is a small change. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
…ully (knative#4144) When `config-domain` configmap was updated, event log from clusteringress sometimes tells us that `Failed to update status for ClusterIngress`. Although this error would be solved automatically by next reconcile loop, we don't know whether it was solved or not because there are no success log. To improve it, this patch adds success logs when clusteringress was updated successfully.
…ully (knative#4144) When `config-domain` configmap was updated, event log from clusteringress sometimes tells us that `Failed to update status for ClusterIngress`. Although this error would be solved automatically by next reconcile loop, we don't know whether it was solved or not because there are no success log. To improve it, this patch adds success logs when clusteringress was updated successfully.
When
config-domainconfigmap was updated, event log fromclusteringress tells us that
Failed to update status for ClusterIngressand
please apply your changes to the latest version and try againlike:Although this error would be solved automatically by
next reconcile loop, any message does not tell us whether it was solved or not.
To improve it, this patch adds success logs when clusteringress
was updated successfully.
Fixes #4143
Proposed Changes
Release Note