Disallow Build #4099
Merged
Disallow Build #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following is the coverage report on pkg/.
|
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
RIP ⚰️ |
joshrider
pushed a commit
to joshrider/serving
that referenced
this pull request
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is scouting M2 of "lemonade" to disable the "just-in-time" Build feature.
This also switches us from our custom
RawExtensiontoruntime.RawExtensionand drops the e2e tests so that we can finally stop vendoring build's type definitions.Let's see how upset the presubmits are with my first cut.