Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment image replaced with runtime image #4030

Merged
merged 3 commits into from
May 9, 2019
Merged

Environment image replaced with runtime image #4030

merged 3 commits into from
May 9, 2019

Conversation

tzununbekov
Copy link
Member

Replace uses of environment image with runtime image

Closes #3985

Proposed Changes

fetchEnvInfo function replaced by fetchRuntimeInfo
environment test image completely removed

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2019
@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2019
knative-prow-robot
knative-prow-robot reviewed May 7, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzununbekov: 0 warnings.

In response to this:

Replace uses of environment image with runtime image

Closes #3985

Proposed Changes

fetchEnvInfo function replaced by fetchRuntimeInfo
environment test image completely removed

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

Hi @tzununbekov. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2019
@vagababov
Copy link
Contributor

/ok-to-test
/assign @dgerd

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2019
dgerd
dgerd reviewed May 7, 2019
View reviewed changes
Copy link

@dgerd dgerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. This is great!

test/conformance/runtime_contract_types.go Outdated
Port string `json:"PORT"`
// MustEnvVars defines environment variables that "MUST" be set.
var MustEnvVars = map[string]string{
"PORT": strconv.Itoa(test.EnvImageServerPort),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this didn't change with the replacement, but we should define the port as part of the service options to fetchRuntimeInfo so the port we are validating matches the port we specified.

We implicitly get the test case of system-defined ports as the runtime container is listening on $PORT so we would not receive a response back to parse if this variable was not set properly. So seems like validating the user-defined case makes the most sense as we could get back a valid port that the system is listening and sending traffic on, but that port could fail to be the one we defined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgerd that makes sense, added user-defined container port

dgerd
dgerd reviewed May 8, 2019
View reviewed changes
test/image_constants.go Outdated
//EnvImageFilePathQueryParam query param to be used with EnvImageFilePathInfoPath to specify filepath
EnvImageFilePathQueryParam = "path"
//RuntimeImageServerPort is the port on which the runtime test-image server starts.
RuntimeImageServerPort = 8800
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more things... now that this fine is a single constant can we just move it into the test file? I don't see a need for it to be shared. All that matters is that the value specified in the test is the same as the value we are looking for. Other tests can choose any other value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 🙂

@tzununbekov
Copy link
Member Author

/test pull-knative-serving-integration-tests

@dgerd
Copy link

dgerd commented May 9, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, tzununbekov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@knative-prow-robot knative-prow-robot merged commit b2df683 into knative:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@dgerd dgerd dgerd left review comments

@ericKlawitter ericKlawitter Awaiting requested review from ericKlawitter

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace uses of environment image with runtime image
5 participants
@tzununbekov @knative-prow-robot @vagababov @dgerd @googlebot