Plumb through configurable defaulting in the webhook. #3546
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/XL
There was a problem hiding this comment.
@mattmoor: 7 warnings.
In response to this:
This makes the default values for TimeoutSeconds and Resources.Limits.CPU
given to Revisions configurable via a new config-defaults configmap that
is monitored by the webhook.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
This is WIP until knative/pkg#342 lands and this is rebased to pull it in from the appropriate place. |
mattmoor
force-pushed
the
webhook-defaulting
branch
from
81eee72 to
5f889f1
Compare
|
/lint |
There was a problem hiding this comment.
@mattmoor: 0 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
mattmoor
force-pushed
the
webhook-defaulting
branch
3 times, most recently
from
be9ff38 to
5e0d375
Compare
This makes the default values for TimeoutSeconds and Resources.Limits.CPU given to Revisions configurable via a new config-defaults configmap that is monitored by the webhook. Fixes: knative#3434 Fixes: knative#3342
mattmoor
force-pushed
the
webhook-defaulting
branch
from
5e0d375 to
19d03db
Compare
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on pkg/.
|
This makes the default values for TimeoutSeconds and Resources.Limits.CPU
given to Revisions configurable via a new config-defaults configmap that
is monitored by the webhook.
Fixes: #3434
Fixes: #3342