Document scale annotations lifetime #3461
Conversation
knative-prow-robot
added
size/XS
docs/scaling/README.md
Outdated
|
|
||
| **NOTE**: These annotations apply for the full lifetime of a `revision`. | ||
| Even when a `revision` is not referenced by any `route`, the minimal pod count | ||
| specified by `autoscaling.knative.dev/minScale` will still be provided. Non-routed |
There was a problem hiding this comment.
I know that @rgregg finds the current behavior unintuitive and wants minScale to only apply to routeable Revisions.
This is mechanically hard, and weakens the promise of minScale, but I can empathize with why he dislikes this. I'm wondering if/how we should change this wording to anticipate and reflect the possibility of a future where this semantic changes. WDYT?
If we don't already we should also document that these annotations are specific to these Autoscaler implementations and not subject to Conformance.
There was a problem hiding this comment.
From this comment, there's reasons to keep current behavior.
I added the description that these annotations are not subject to Conformance in case we make the change in future.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, yanweiguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/test pull-knative-serving-upgrade-tests |
2 similar comments
|
/test pull-knative-serving-upgrade-tests |
|
/test pull-knative-serving-upgrade-tests |
|
/test pull-knative-serving-upgrade-tests |
Fixes #2720.