Multiple runs on scale-from-zero test #3059
Conversation
knative-prow-robot
added
the
size/M
There was a problem hiding this comment.
@greghaynes: 0 warnings.
In response to this:
This is a fairly noisy test, lets do 5 runs and report a min/max/avg so
we can get more clear data.Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
we have the fortio integration to send load. If you can use that, it provides all these stats already. |
| var avg time.Duration | ||
| var avg, min, max time.Duration | ||
| min = durations[0] | ||
| max = durations[0] | ||
|
|
||
| for _, dur := range durations { |
There was a problem hiding this comment.
| for _, dur := range durations { | |
| for _, dur := range durations[1:] { |
There was a problem hiding this comment.
although the min/max checks are a noop on the first loop, I need to run it for the avg aggregating.
There was a problem hiding this comment.
yeah, but you can also do avg=durations[0], no? :)
There was a problem hiding this comment.
sure, was optimizing for LOC :)
|
/uncc @adrcunha |
greghaynes
force-pushed
the
feature/scale-from-zero-multirun
branch
from
3830126 to
2ef0f44
Compare
knative-prow-robot
added
the
area/test-and-release
greghaynes
force-pushed
the
feature/scale-from-zero-multirun
branch
2 times, most recently
from
d6e51d6 to
b2b4cca
Compare
This is a fairly noisy test, lets do 5 runs and report a min/max/avg so we can get more clear data.
greghaynes
force-pushed
the
feature/scale-from-zero-multirun
branch
from
b2b4cca to
6905b32
Compare
|
/retest |
|
/approve |
knative-prow-robot
added
the
approved
|
/lgtm |
knative-prow-robot
added
do-not-merge/hold
|
@vagababov Could you PTAL? Thanks! |
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: greghaynes, srinivashegde86, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a fairly noisy test, lets do 5 runs and report a min/max/avg so
we can get more clear data.
Release Note