Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add root ca for Controller HA test with https #11471

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Add root ca for Controller HA test with https #11471

merged 1 commit into from
Jun 7, 2021

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jun 7, 2021

This patch adds test.AddRootCAtoTransport for prober in TestControllerHA.

Release Note

NONE

@nak3
Add root ca for Controller HA test with https
617d941 
This patch adds `test.AddRootCAtoTransport` for prober in TestControllerHA.
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 7, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2021
@nak3
Copy link
Contributor Author

nak3 commented Jun 7, 2021

Test passed mysteriously sometimes 🤔 https://testgrid.k8s.io/knative-serving#knative-serving-https

When it failed, the prober failed as expected: prober.go:165: "https://controller-h-a-sdjetvyp.serving-tests.example.com" error: response: <nil> did not pass checks: Get "https://controller-h-a-sdjetvyp.serving-tests.example.com": x509: certificate signed by unknown authority.

@markusthoemmes
Copy link
Contributor

/test foo

@knative-prow-robot
Copy link
Contributor

@markusthoemmes: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-knative-serving-build-tests
  • /test pull-knative-serving-unit-tests
  • /test pull-knative-serving-upgrade-tests
  • /test pull-knative-serving-istio-latest-mesh
  • /test pull-knative-serving-istio-latest-mesh-tls
  • /test pull-knative-serving-istio-latest-no-mesh
  • /test pull-knative-serving-istio-latest-no-mesh-tls
  • /test pull-knative-serving-istio-stable-mesh
  • /test pull-knative-serving-istio-stable-mesh-tls
  • /test pull-knative-serving-istio-stable-no-mesh
  • /test pull-knative-serving-istio-stable-no-mesh-tls
  • /test pull-knative-serving-istio-stable-no-mesh-tls-with-http01
  • /test pull-knative-serving-kourier-stable
  • /test pull-knative-serving-kourier-stable-tls
  • /test pull-knative-serving-contour-latest
  • /test pull-knative-serving-contour-tls
  • /test pull-knative-serving-ambassador-latest
  • /test pull-knative-serving-ambassador-latest-tls
  • /test pull-knative-serving-kong-latest
  • /test pull-knative-serving-kong-latest-tls
  • /test pull-knative-serving-https

Use /test all to run the following jobs:

  • pull-knative-serving-build-tests
  • pull-knative-serving-unit-tests
  • pull-knative-serving-upgrade-tests
  • pull-knative-serving-istio-stable-no-mesh
  • pull-knative-serving-istio-stable-no-mesh-tls

In response to this:

/test foo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markusthoemmes
Copy link
Contributor

/test pull-knative-serving-https

markusthoemmes
markusthoemmes approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7253895 into knative:main Jun 7, 2021
@nak3 nak3 deleted the add-tls-probe branch June 10, 2021 06:46
nak3 added a commit to nak3/serving that referenced this pull request Jun 22, 2021
@nak3
Add root ca for Controller HA test with https (knative#11471)
eb96b30 
This patch adds `test.AddRootCAtoTransport` for prober in TestControllerHA.
openshift-merge-robot pushed a commit to openshift/knative-serving that referenced this pull request Jun 22, 2021
@nak3
Add root ca for Controller HA test with https (knative#11471) (#815)
ce88e68 
This patch adds `test.AddRootCAtoTransport` for prober in TestControllerHA.
nak3 added a commit to nak3/serving that referenced this pull request Jul 1, 2021
@nak3
Add root ca for Controller HA test with https (knative#11471)
d7b7104 
This patch adds `test.AddRootCAtoTransport` for prober in TestControllerHA.
openshift-merge-robot pushed a commit to openshift/knative-serving that referenced this pull request Jul 1, 2021
@nak3
[CP][0.23]Add root ca for Controller HA test with https (knative#11471)…
75ffe62 
… (#836)

* Add root ca for Controller HA test with https (knative#11471)

This patch adds `test.AddRootCAtoTransport` for prober in TestControllerHA.

* stick serverless-operator branch

* Revert "stick serverless-operator branch"

This reverts commit d2be74a.

* Add v0.23 label to manifests (#833)

* Remove config/domainmapping

* Add 0.23 label

* Update label

* Add back DomainMapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Assignees

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nak3 @markusthoemmes @knative-prow-robot