Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Conformance test for user set headers #3208

Closed
dgerd opened this issue Feb 13, 2019 · 2 comments · Fixed by #4411
Closed

Add Conformance test for user set headers #3208

dgerd opened this issue Feb 13, 2019 · 2 comments · Fixed by #4411
Assignees
@dgerd
Labels
area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding. kind/spec Discussion of how a feature should be exposed to customers.
Milestone
0.7.x

Comments

@dgerd
Copy link

dgerd commented Feb 13, 2019 •
edited
Loading

In what area(s)?

/area API
/area test-and-release

Describe the feature

User set headers SHOULD be passed through to the user container for each request. This issue is to add a conformance test that sends a headers and validates that the set header appears in the response from the runtime test container.

This is a follow up to #3116 as it requires some additional changes to https://github.com/knative/pkg to make it possible to set request headers when using pkgTest.WaitForEndpointState.
@dgerd dgerd added the kind/feature Well-understood/specified features, ready for coding. label Feb 13, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/spec Discussion of how a feature should be exposed to customers. labels Feb 13, 2019
@dgerd
Copy link
Author

dgerd commented Feb 13, 2019

/assign @dgerd

@dgerd dgerd mentioned this issue Feb 13, 2019
Merged
@dgerd dgerd removed their assignment Mar 19, 2019
@dgerd
Copy link
Author

dgerd commented Jun 6, 2019

I have the bandwidth again to pick this back up.

/assign @dgerd

dgerd pushed a commit to dgerd/serving that referenced this issue Jun 18, 2019
Add test case for user set headers
5fbe7a2 
Make sure that headers supplied by the user on the request are available
within the container.

Fixes knative#3208
@dgerd dgerd mentioned this issue Jun 18, 2019
Merged
knative-prow-robot pushed a commit that referenced this issue Jun 20, 2019
@knative-prow-robot
Add test case for user set headers (#4411)
ef6ad93 
* Add test case for user set headers

Make sure that headers supplied by the user on the request are available
within the container.

Fixes #3208

* Change to use interface for opts

* Make constants

* Handle invalid options

* Fix type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgerd dgerd

Labels
area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding. kind/spec Discussion of how a feature should be exposed to customers.
Projects
None yet
Milestone
0.7.x
Development

Successfully merging a pull request may close this issue.

Add test case for user set headers dgerd/serving
3 participants
@mattmoor @knative-prow-robot @dgerd