Increase default and max revision timeout. (#2867)

* Increase default and max revision timeout. * Use 10 mins instead of 20 mins for max timeout.
knative · Jan 8, 2019 · 4d198db · 4d198db
1 parent fb454f3
commit 4d198db
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/apis/networking/v1alpha1/clusteringress_defaults.go b/pkg/apis/networking/v1alpha1/clusteringress_defaults.go
@@ -24,7 +24,7 @@ import (
 
 const (
 	// DefaultTimeout will be set if timeout not specified.
-	DefaultTimeout = 5 * time.Minute
+	DefaultTimeout = 10 * time.Minute
 	// DefaultRetryCount will be set if Attempts not specified.
 	DefaultRetryCount = 3
 )

diff --git a/pkg/apis/serving/v1alpha1/revision_defaults.go b/pkg/apis/serving/v1alpha1/revision_defaults.go
@@ -18,7 +18,7 @@ package v1alpha1
 
 const (
 	// defaultTimeoutSeconds will be set if timeoutSeconds not specified.
-	defaultTimeoutSeconds = 60
+	defaultTimeoutSeconds = 5 * 60
 )
 
 func (r *Revision) SetDefaults() {

diff --git a/pkg/apis/serving/v1alpha1/revision_validation_test.go b/pkg/apis/serving/v1alpha1/revision_validation_test.go
@@ -548,9 +548,9 @@ func TestRevisionSpecValidation(t *testing.T) {
 			Container: corev1.Container{
 				Image: "helloworld",
 			},
-			TimeoutSeconds: 600,
+			TimeoutSeconds: 6000,
 		},
-		want: apis.ErrOutOfBoundsValue("600s", "0s",
+		want: apis.ErrOutOfBoundsValue("6000s", "0s",
 			fmt.Sprintf("%ds", int(netv1alpha1.DefaultTimeout.Seconds())),
 			"timeoutSeconds"),
 	}, {