Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Update the manifest of knative serving and the dependencies for 0.12.0 release #264

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Update the manifest of knative serving and the dependencies for 0.12.0 release #264

merged 2 commits into from
Jan 23, 2020

Conversation

houshengbo
Copy link

@houshengbo houshengbo commented Jan 23, 2020 •
edited
Loading

Proposed Changes

  • This PR is a prep for the release of the version 0.12.0.

Release Note

@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Jan 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo houshengbo changed the title Update deps Update the manifest of knative serving and the dependencies for 0.12.0 release Jan 23, 2020
jcrossley3
jcrossley3 reviewed Jan 23, 2020
View reviewed changes
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've checked for any obsolete resources in the new manifest? It's kinda hard to tell due to their re-ordering, but nothing jumped out at me.

@houshengbo
Copy link
Author

@jcrossley3 I did it. Manually compared one-by-one. No obsolete resource was found.

@jcrossley3
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot merged commit 15de161 into knative:master Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcrossley3 jcrossley3 jcrossley3 left review comments

@greghaynes greghaynes Awaiting requested review from greghaynes

@k4leung4 k4leung4 Awaiting requested review from k4leung4

Assignees

@jcrossley3 jcrossley3

Labels
approved cla: yes Author(s) signed a CLA. lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@houshengbo @knative-prow-robot @jcrossley3 @googlebot