Letting flags be changed from outside #223
Conversation
There was a problem hiding this comment.
@cardil: 0 warnings.
In response to this:
Proposed Changes
- Letting flags be changed from outside
Changing those flags is needed to perform tests on RH operators.- Adding Intellij, and vandors excluded files to gitignore
Implementation
This PR let change test flags from outside. It can be done either by:
- declaring environmental variables:
TEST_NAMESPACE, andTEST_RESOURCE,- using
-ldflags "-X knative.dev/serving-operator/test.ServingOperatorNamespace=knative-serving"Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
Hi @cardil. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR mirrors knative/eventing-operator#21 |
| @@ -1,6 +1,13 @@ | |||
| # Temporary Build Files | |||
| build/_output | |||
| build/_test | |||
| # Goland | |||
| .idea | |||
There was a problem hiding this comment.
not 100% sure on getting this in.... I guess... shouldn't those be on your own global .gitignore ?
There was a problem hiding this comment.
You mean by using git config --global core.excludesfile option?
I think not many people actually use that. I didn't hear of that option, nor any of developers in my office (I know that's not representative 😉)
On top that it is easier for newcomers, so that repo declares those ignores.
| vendor/**/OWNERS | ||
| # Test Infra Dev Stats | ||
| vendor/knative.dev/test-infra/devstats | ||
|
|
There was a problem hiding this comment.
I would say not change this .gitignore by far.
The script under /hack/update-deps.sh is supposed to update the dependencies, and remove the useless files, including OWNERS. However, some packages may keep them, based on the configuration in Gopkg.toml. Let's keep the dependencies(with all the files) based on what is generated by /hack/update-deps.sh.
| if !set { | ||
| value = defaultValue | ||
| } | ||
| return value |
|
/ok-to-test |
Also adding some extra OWNER files and test-infra/devstats from vendor directory that shouldn't be commited
This commit let change test flags from outside. It can be done either by: * declaring environmental variables: `TEST_NAMESPACE`, and `TEST_RESOURCE`, * using `-ldflags "-X knative.dev/serving-operator/test.ServingOperatorNamespace=knative-serving"` Changing those flags is needed to perform tests on RH operators.
cardil
force-pushed
the
bugfix/let-chenge-test-flags
branch
from
841ae74 to
15b182e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, k4leung4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Adding Goland to gitignore Also adding some extra OWNER files and test-infra/devstats from vendor directory that shouldn't be commited * Letting flags be changed from outside This commit let change test flags from outside. It can be done either by: * declaring environmental variables: `TEST_NAMESPACE`, and `TEST_RESOURCE`, * using `-ldflags "-X knative.dev/serving-operator/test.ServingOperatorNamespace=knative-serving"` Changing those flags is needed to perform tests on RH operators.
* Adding Goland to gitignore Also adding some extra OWNER files and test-infra/devstats from vendor directory that shouldn't be commited * Letting flags be changed from outside This commit let change test flags from outside. It can be done either by: * declaring environmental variables: `TEST_NAMESPACE`, and `TEST_RESOURCE`, * using `-ldflags "-X knative.dev/serving-operator/test.ServingOperatorNamespace=knative-serving"` Changing those flags is needed to perform tests on RH operators.
Proposed Changes
Changing those flags is needed to perform tests on RH operators.
Implementation
This PR let change test flags from outside. It can be done either by:
TEST_NAMESPACE, andTEST_RESOURCE,-ldflags "-X knative.dev/serving-operator/test.ServingOperatorNamespace=knative-serving"Release Note