Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Initial API fields for HA control plane #320

Closed
pmorie opened this issue Mar 3, 2020 · 4 comments · Fixed by #337
Closed

Initial API fields for HA control plane #320

pmorie opened this issue Mar 3, 2020 · 4 comments · Fixed by #337

Comments

@pmorie
Copy link
Member

pmorie commented Mar 3, 2020

Problem

Now that leader election has landed in 0.13, we should make the operator deploy an HA configuration by default.

Persona:

Users of the operator

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
Simple

@evankanderson
Copy link
Member

We had a discussion in the WG meeting on 3/3 that we don't want to double the resources for Minikube, so me may need some sort of controllable option and/or auto-sizing (i.e. "turn off HA if there is only 1 node in the cluster").

@pmorie pmorie changed the title Create HA configuration for serving by default Initial API fields for HA control plane Mar 10, 2020
@pmorie
Copy link
Member Author

pmorie commented Mar 10, 2020

I'm renaming this issue to be for the initial API changes that allow you to specify an HA installation.

@pmorie
Copy link
Member Author

pmorie commented Mar 10, 2020

After discussion with @jcrossley3, i offer the following proposal:

type KnativeServingSpec struct {
  // other fields omitted

  // non-nil indicates HA is requested
  HighAvailability *HighAvailability
}

type HighAvailability struct {
  // Replicas is the number of replicas to run for the HA parts of the control plane
  Replicas int
}

@pmorie
Copy link
Member Author

pmorie commented Mar 13, 2020

part of knative/pkg#1007

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants