Configmap for defaults #306
Labels
Comments
|
I think what I'd like to see here is changing these interfaces to pass a |
mattmoor
added a commit
to mattmoor/pkg
that referenced
this issue
Mar 20, 2019
mattmoor
added a commit
to mattmoor/pkg
that referenced
this issue
Mar 27, 2019
… context.
Clients of webhook can now decorate the request context with additional metadata
via:
```
ac := &AdmissionController{
... // As before
WithContext: func(ctx context.Context) context.Context {
// logic to attach stuff to ctx
}
}
```
This metadata can then be accessed off of the context in methods like
`SetDefaults` and `Validate` on types registered as webhook handlers.
Fixes: knative#306
mattmoor
added a commit
to mattmoor/pkg
that referenced
this issue
Mar 27, 2019
… context.
Clients of webhook can now decorate the request context with additional metadata
via:
```
ac := &AdmissionController{
... // As before
WithContext: func(ctx context.Context) context.Context {
// logic to attach stuff to ctx
}
}
```
This metadata can then be accessed off of the context in methods like
`SetDefaults` and `Validate` on types registered as webhook handlers.
Fixes: knative#306
knative-prow-robot
pushed a commit
that referenced
this issue
Mar 27, 2019
… context. (#342) Clients of webhook can now decorate the request context with additional metadata via: ``` ac := &AdmissionController{ ... // As before WithContext: func(ctx context.Context) context.Context { // logic to attach stuff to ctx } } ``` This metadata can then be accessed off of the context in methods like `SetDefaults` and `Validate` on types registered as webhook handlers. Fixes: #306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
I would like to be able to use a config map when setting defaults in the webhook.
Actual Behavior
However, because the webhook is common and abstracted, I cannot construct one and get it through to the defaulting function. E.g. I would like to pass in a config map watcher here and have that config map passed to the
SetDefaultsfunction here.Additional Info
I used a package scoped var to work around this limitation in knative/serving#3103.
The text was updated successfully, but these errors were encountered: