refactor: switch to async/await syntax #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5c47e3c.
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor manual promise chaining to
async/awaitsyntax for readability and maintainability. This should be a completely transparent change, except that errors thrown by the loader may look slightly different than before, as they're no longer being constructed manually withincatchblocks/callbacks.Note that per https://node.green/#ES2017-features-async-functions,
async/awaitsyntax has been supported natively since Node 7.10, which is below this package's specified minimum version (12), as well as the specified minimum versions of both webpack and protobufjs. Therefore, this isn't being treated as a breaking change.