We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Indicator.override
_prevIndicator
shouldUpdate
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In
KLineChart/src/component/Indicator.ts
Line 385 in 6c839d8
_prevIndicator is a deep clone, while in
Line 344 in 6c839d8
attribute like figures are compared using identity. Thus any update to the indicator like toggling visible value will always result in an update.
figures
visible
I think _prevIndicator should be a shallow clone
this._prevIndicator = { ...this }
The text was updated successfully, but these errors were encountered:
The same logic applies to Overlay which compares extendData and styles which are objects.
Overlay
extendData
styles
KLineChart/src/component/Overlay.ts
Line 276 in 6c839d8
Line 346 in 6c839d8
Sorry, something went wrong.
I was mistaken. Since the override is merged using merge, figures and calcParams which are arrays are overwritten.
merge
calcParams
No branches or pull requests
In
KLineChart/src/component/Indicator.ts
Line 385 in 6c839d8
_prevIndicator
is a deep clone, while inKLineChart/src/component/Indicator.ts
Line 344 in 6c839d8
attribute like
figures
are compared using identity. Thus any update to the indicator like togglingvisible
value will always result in an update.I think
_prevIndicator
should be a shallow cloneThe text was updated successfully, but these errors were encountered: