-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for workspace-wide version setting and bumping #814
Conversation
8df12b0
to
f3b7eb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
@epage so the wanted behavior is to update the workspace-wide version if one of the two is true:
Is that correct ? |
a57f554
to
58718a2
Compare
All fixed, there is only the one question about |
Sorry for the delay; got caught up in clap v4 release stuff.
A simpler take is that if a package is specified that uses We already have command-line flag processing separated from iterating over workspace members, so we can just keep that. |
ac45e0c
to
4c9b317
Compare
No worries, you don't owe me any of your free time 😄 I fixed a bug where workspace declared in the same I hope there aren't more bugs I missed, I think I tested pretty much everything now 😅 |
4c9b317
to
febe6ef
Compare
FYI there are some things that aren't quite working out for me with this PR. I think part of it is the base you are working off of. I'm trying to get some changes made that will make adding workspace inheritance more comprehensible. |
Alright, things are in better shape. My assumption is that we will partition the selected manifests into two groups: those inheriting and those that aren't. When we call |
Ah no, workspace.version is not updated correctly yet |
febe6ef
to
ad68355
Compare
Rebased, it was indeed much much simpler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, even cleaner than I expected! Good job on finding such a simple solution! I hadn't thought to take advantage of the existing update_dependents
b09a2bb
to
4b8120d
Compare
4b8120d
to
5a9d28e
Compare
Thanks! |
This PR adds support for the
workspace.package.version
added in Cargo 1.64.0.I tried to make very atomic commits to make it easier to review since it needed
quite some refactoring, I advise to review commit by commit else it will be quite
heavy to read.
Closes #752