-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ multi readgroup input #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 fix custom RG DS string 🔧 add kallisto multi-rg input 🔧 star solo file manifest input, output, log
🚧 centralize record schema 🐛 outputbasename prefix to cutadapt stats
📚 update readme
migbro
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a behemoth! Impressive work. Just a couple minor typos I saw, but no obvious flaws in logic that I could see
Co-authored-by: Miguel Brown <miguel.a.brown@gmail.com>
wongjessica93
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update brings multi-read group processing to RNAseq.
The workflow can now handle multiple inputs in the form of lists:
input_aligned_reads
input_pe_reads
input_pe_mates
input_se_reads
Aligned reads inputs have their
@RG
headers pulled and used for processing. Otherwise read groups inputs are also provided in list format using:input_pe_rg_strs
input_se_rg_strs
These lists are converted to a record schema I have defined externally and import throughout the workflow. STAR and Kallisto had their inputs updated to take this record input to assist in building the command line.
This approach mirrors what we have in the DNAseq alignment workflows. Many of the new tools are stolen directly from the alignment workflow repo.
Closes https://d3b.atlassian.net/browse/BIXU-3780
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: