Fix rubocop issues

Author: kfischer-okarin

.circleci/config.yml

@@ -8,5 +8,5 @@ jobs:
     steps:
       - checkout
       - run: bundle install
-      # - ruby/rubocop-check
+      - ruby/rubocop-check
       - ruby/rspec-test

.rubocop.yml

@@ -0,0 +1,16 @@
+AllCops:
+  TargetRubyVersion: 2.4
+  NewCops: enable
+
+Style/BlockDelimiters:
+  EnforcedStyle: semantic
+
+Style/Documentation:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 120
+
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*

Gemfile

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-source "https://rubygems.org"
-
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+source 'https://rubygems.org'
 
 gemspec

Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
@@ -24,8 +26,8 @@
 #  * zeus: 'zeus rspec' (requires the server to be started separately)
 #  * 'just' rspec: 'rspec'
 
-guard :rspec, cmd: "bundle exec rspec" do
-  require "guard/rspec/dsl"
+guard :rspec, cmd: 'bundle exec rspec' do
+  require 'guard/rspec/dsl'
   dsl = Guard::RSpec::Dsl.new(self)
 
   # RSpec files

bin/oblivion

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'oblivion'
 
-open(ARGV[0]) do |f|
+File.open(ARGV[0]) do |f|
   puts Oblivion.uglify(f.read)
 end

lib/oblivion.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'unparser'
 
 require_relative 'oblivion/nodes'

lib/oblivion/base_processor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'ast'
 
 module Oblivion

lib/oblivion/class_uglifier.rb

@@ -1,8 +1,11 @@
+# frozen_string_literal: true
+
 require 'securerandom'
 
 module Oblivion
   class ClassUglifier < BaseProcessor
     def initialize(methods)
+      super()
       @method_names = {}
       methods.each do |name|
         @method_names[name] = random_method_name(name)
@@ -14,9 +17,7 @@ def initialize(methods)
     def on_def(node)
       result = node
       result = result.with_name @method_names[node.name] if @method_names.key?(node.name)
-      result = result.with_body MethodUglifier.new(@method_names).process(node.body)
-
-      result
+      result.with_body MethodUglifier.new(@method_names).process(node.body)
     end
 
     # TODO: Uglify instance_variables
@@ -35,8 +36,8 @@ def on_def(node)
     #   node.updated(nil, new_children)
     # end
 
-    alias :on_class :uglify_class
-    alias :on_sclass :uglify_class
+    alias on_class uglify_class
+    alias on_sclass uglify_class
 
     private
 

lib/oblivion/method_finder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'set'
 
 module Oblivion
@@ -30,19 +32,20 @@ def on_send(node)
       case called_method
       when :public, :protected, :private
         @access_modifier = called_method
-      # TODO: Uglify instance_variables
-      # when :attr_reader, :attr_writer, :attr_accessor
-      #   method_names = node.children[2..-1].map { |n| n.children[0] }
-      #   method_names.each do |method_name|
-      #     add_to_result method_name
-      #   end
+        # TODO: Uglify instance_variables
+        # when :attr_reader, :attr_writer, :attr_accessor
+        #   method_names = node.children[2..-1].map { |n| n.children[0] }
+        #   method_names.each do |method_name|
+        #     add_to_result method_name
+        #   end
       end
       node
     end
 
     private
 
     def initialize
+      super
       @access_modifier = :public
     end
 

lib/oblivion/method_uglifier.rb

@@ -1,13 +1,16 @@
+# frozen_string_literal: true
+
 module Oblivion
   class MethodUglifier < BaseProcessor
     def initialize(method_names)
+      super()
       @method_names = method_names
     end
 
     def on_send(node)
       receiver, name, args = node.children
 
-      new_children = [*node.children]
+      new_children = Array.new(node.children)
       if [nil, AST::Node.new(:self)].include? receiver
         new_children[1] = @method_names[name] || name
       else

lib/oblivion/nodes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'strings-case'
 
 module Oblivion
@@ -21,7 +23,7 @@ def define_getter(name, child_index)
 
         def define_update_method(name, child_index)
           define_method :"with_#{name}" do |new_value|
-            new_children = [*children]
+            new_children = Array.new(children)
             new_children[child_index] = new_value
             updated(nil, new_children)
           end
@@ -37,10 +39,14 @@ class Def < Base
 
     def parse(node)
       class_name = Strings::Case.pascalcase(node.type.to_s)
-      return node unless Nodes.const_defined?(class_name, inherit = false)
+      return node unless own_constant_defined?(class_name)
 
       node_class = Nodes.const_get(class_name)
       node_class.new(node.type, node.children, location: node.location)
     end
+
+    def own_constant_defined?(name)
+      const_defined?(name, false)
+    end
   end
 end

lib/oblivion/uglifier.rb

@@ -1,14 +1,17 @@
+# frozen_string_literal: true
+
 module Oblivion
   class Uglifier < BaseProcessor
     def self.process(ast)
       new.process(ast)
     end
 
-    alias :on_class :uglify_class
+    alias on_class uglify_class
 
     private
 
     def initialize
+      super
       @method_names_by_class = {}
     end
   end

lib/oblivion/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Oblivion
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.0'
 end

oblivion.gemspec

@@ -11,18 +11,17 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/kfischer-okarin/oblivion'
   spec.license       = 'MIT'
 
-
-  spec.required_ruby_version = '>= 2.0.0'
+  spec.required_ruby_version = '>= 2.4.0'
 
   spec.add_dependency             'parser',                '~> 2.7'
-  spec.add_dependency             'unparser',              '~> 0.4.7'
   spec.add_dependency             'strings-case',          '~> 0.3.0'
+  spec.add_dependency             'unparser',              '~> 0.4.7'
 
-  spec.add_development_dependency 'rspec',                 '~> 3.9'
+  spec.add_development_dependency 'codecov',               '~> 0.2.6'
   spec.add_development_dependency 'guard-rspec',           '~> 4.7'
+  spec.add_development_dependency 'rspec',                 '~> 3.9'
   spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
   spec.add_development_dependency 'simplecov',             '~> 0.19.0'
-  spec.add_development_dependency 'codecov',               '~> 0.2.6'
 
   spec.add_development_dependency 'rubocop',               '~> 0.89.1'
   spec.add_development_dependency 'rubocop-rspec',         '~> 1.43'

spec/oblivion/uglifier_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../spec_helper'
 
 RSpec.describe Oblivion::Uglifier do
@@ -122,7 +124,11 @@ def method; end
       #       RUBY
       #     }
       #     let(:expected_body) {
-      #       a_node(:send, nil, method_definer, an_object_not_eq_to(s(:sym, :method)), an_object_not_eq_to(s(:sym, :method2)))
+      #       a_node(:send,
+      #              nil,
+      #              method_definer,
+      #              an_object_not_eq_to(s(:sym, :method)),
+      #              an_object_not_eq_to(s(:sym, :method2)))
       #     }
 
       #     include_examples 'expected class body'
@@ -145,8 +151,8 @@ def method; end
 
         let(:expected_body) {
           a_node(:class,
-                  s(:const, nil, :Inline), nil,
-                  including(a_method_definition(an_object_not_eq_to(:method))))
+                 s(:const, nil, :Inline), nil,
+                 including(a_method_definition(an_object_not_eq_to(:method))))
         }
 
         include_examples 'expected class body'
@@ -164,7 +170,7 @@ def method; end
 
         let(:expected_body) {
           a_node(:sclass, s(:self),
-                  including(a_method_definition(an_object_not_eq_to(:method))))
+                 including(a_method_definition(an_object_not_eq_to(:method))))
         }
 
         include_examples 'expected class body'
@@ -254,8 +260,7 @@ def method; end
         s(:block,
           s(:send, s(:begin, s(:irange, s(:int, 1), s(:int, 10))), :each),
           s(:args, s(:procarg0, s(:arg, :i))),
-          method_call_with_new_name
-        )
+          method_call_with_new_name)
       }
 
       include_examples 'expected method body'

spec/oblivion_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'spec_helper'
 
 RSpec.describe Oblivion do

spec/spec_helper.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'ast'
 require 'unparser'
 
-require_relative 'support/matchers.rb'
-require_relative 'support/coverage.rb'
-require_relative '../lib/oblivion.rb'
+require_relative 'support/matchers'
+require_relative 'support/coverage'
+require_relative '../lib/oblivion'
 
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|
@@ -30,6 +32,7 @@ def self_and_descendants
 
       children.each do |c|
         next unless c.is_a? AST::Node
+
         c.self_and_descendants.each do |cc|
           y << cc
         end

spec/support/coverage.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start do
   add_filter 'spec'

spec/support/matchers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Matchers.define_negated_matcher :an_object_not_eq_to, :an_object_eq_to
 
 RSpec::Matchers.define :a_node do |type, *children|
@@ -23,7 +25,7 @@ def initialize(name)
 
     def matches?(value)
       result = value.type == :def && values_match?(@name, value.children[0])
-      result = result && values_match?(@body_matcher, value.children[2]) if @body_matcher
+      result &&= values_match?(@body_matcher, value.children[2]) if @body_matcher
       result
     end
 
@@ -44,6 +46,6 @@ def a_method_definition(name)
   end
 end
 
-RSpec.configure do |config|
+RSpec.configure do |_config|
   include CustomMatchers
 end