fix: url regex fails if run twice immediately

Author: kevinand11

package.json

@@ -24,15 +24,15 @@
 	"devDependencies": {
 		"@commitlint/cli": "^17.7.1",
 		"@commitlint/config-conventional": "^17.7.0",
-		"@types/node": "^20.5.0",
-		"@typescript-eslint/eslint-plugin": "^6.4.0",
-		"@typescript-eslint/parser": "^6.4.0",
-		"eslint": "^8.47.0",
+		"@types/node": "^20.6.0",
+		"@typescript-eslint/eslint-plugin": "^6.6.0",
+		"@typescript-eslint/parser": "^6.6.0",
+		"eslint": "^8.49.0",
 		"eslint-plugin-promise": "^6.1.1",
 		"husky": "^8.0.3",
 		"standard-version": "^9.5.0",
-		"typescript": "^5.1.6",
-		"vitest": "^0.34.1"
+		"typescript": "^5.2.2",
+		"vitest": "^0.34.4"
 	},
 	"files": [
 		"LICENSE",

src/rules/strings.ts

@@ -47,5 +47,5 @@ export const isUrl = (error = 'is not a valid url') => makeRule<string>((value)
 	const v = isString()(value)
 	if (!v.valid) return v
 	const val = value as string
-	return urlRegex.test(val) ? isValid(val) : isInvalid([error], val)
+	return urlRegex().test(val) ? isValid(val) : isInvalid([error], val)
 })

src/utils/functions/index.ts

@@ -26,7 +26,7 @@ export const trimToLength = (body: string, length: number) => {
 }
 
 export const extractUrls = (text: string) => {
-	const urls = text.match(urlRegex) || [] as string[]
+	const urls = text.match(urlRegex()) || [] as string[]
 	return urls.filter(((url, index) => urls.indexOf(url) === index)).map((url) => {
 		url = url.trim()
 		return {

src/utils/regexes.ts

@@ -1,4 +1,4 @@
 import url from 'url-regex-safe'
 
-export const urlRegex: RegExp = url()
+export const urlRegex: () => RegExp = url
 export const emailRegex = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/