Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omegaconf breaks with a custom resolver providing a datetime #4126

Closed
PetitLepton opened this issue Aug 29, 2024 · 3 comments
Closed

Omegaconf breaks with a custom resolver providing a datetime #4126

PetitLepton opened this issue Aug 29, 2024 · 3 comments
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@PetitLepton
Copy link
Contributor

Description

Omegaconf raises an exception on versions 0.19.* when a custom resolver providing a datetime object (or timedelta for example).

Context

I was trying to use custom resolvers to parse to datetime and timedelta.

Steps to Reproduce

https://github.com/PetitLepton/kedro-runtime-params

Expected Result

Custom resolvers with any output should work.

Actual Result

omegaconf.errors.UnsupportedValueType: Value 'timedelta' is not a supported primitive type
    full_key: example-duration
    object_type=dict

Your Environment

  • Kedro version used (pip show kedro or kedro -V): > 0.18.*
  • Python version used (python -V): 3.11.*
  • Operating system and version: Ubuntu 20.04
@ElenaKhaustova
Copy link
Contributor

Thank you, @PetitLepton, for opening the issue!

@ElenaKhaustova
Copy link
Contributor

ElenaKhaustova commented Aug 29, 2024

Additional context

Relates to #3620

User tested the code example provided with 0.18.14 and 0.19.8 kedro versions - the issue appears only when switching to 0.19.x. OmegaConf version used in both tests was the same - 2.3.0.

@ElenaKhaustova ElenaKhaustova added the Issue: Bug Report 🐞 Bug that needs to be fixed label Aug 29, 2024
@noklam
Copy link
Contributor

noklam commented Sep 9, 2024

Duplicated as #3620, we will fix this in the other issue

@noklam noklam closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
None yet
Development

No branches or pull requests

3 participants