Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro new includes empty data_science folder in pipelines #3955

Closed
yury-fedotov opened this issue Jun 14, 2024 · 5 comments
Closed

kedro new includes empty data_science folder in pipelines #3955

yury-fedotov opened this issue Jun 14, 2024 · 5 comments
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@yury-fedotov
Copy link
Contributor

Description

kedro new includes empty data_science folder in pipelines even if I say to not include a pipeline example during kedro new workflow.

Steps to Reproduce

  1. Initialize kedro new with all defaults except pyspark, and reply no when it asks about example pipeline
  2. See that an empty data_science folder in pipelines has been created as part of the project

Expected Result

It should not be created.

Your Environment

  • Kedro version used (pip show kedro or kedro -V): 0.19.6
  • Python version used (python -V): 3.10
  • Operating system and version: MacOS
@merelcht
Copy link
Member

Hi @yury-fedotov, thanks for reporting this issues. I tried to reproduce the issue and can see there's an empty data_science folder inside tests/pipelines/. This should indeed not be there. Feel free to open a PR to fix this, but otherwise the team will take it on.

@merelcht merelcht added the Issue: Bug Report 🐞 Bug that needs to be fixed label Jun 14, 2024
@merelcht
Copy link
Member

Actually this was quite a small change so I've opened a PR for it here: #3956

@yury-fedotov can you confirm you are also talking about the tests directory?

@yury-fedotov
Copy link
Contributor Author

yury-fedotov commented Jun 14, 2024

Hi @merelcht ! nope, actually this is not at all related to tests. In my case I got generated in pipelines folder as if it is an example pipeline.

Just an empty folder named data_science (not even a Python package, i.e. had no __init__.py inside).

@merelcht
Copy link
Member

@yury-fedotov in that case can you specify how you created the project? I did kedro new --name=reprtest --example=no --tools=lint,test,viz,data,log,docs and the same through the interactive flow, but I don't get a data_science folder in src/pipelines only in tests as I mentioned before.

@yury-fedotov
Copy link
Contributor Author

@merelcht hey! Sorry I disappeared for a while. So I did another check and you were right: the bug I described exists but only in tests. See here:

Screenshot 2024-06-29 at 8 37 40 PM

It it kedro 0.19.6 and I did a test on Jun 29 2024.

#3956 should close it, so whenever it gets released, this bug should be gone.

Thanks for fixing it!

I am closing this issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants