You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our current test setup starters & framework are linked and look to the "latest" version. At release time it leads to a situation where it's looking for the unreleased version and tests fail because of it.
Implement a way to fall back to the latest released version OR specify a specific version.
As a result, when we need to release both kedro-starters and kedro, we cannot specify a custom kedro-starters version on the kedro side. So we have to make a release with failing tests and only after making sure that tests are passing at the CI.
Possible Implementation
We already have a checkout argument that allows pointing to a specific tag or branch, which is used as an optional argument for the kedro new command. We can add a constant to specify the checkout argument as we do for starters repo:
Then, in case the checkout argument was provided, it will be used instead of constant. For the rest of the cases, including testing, we will use the constant and we only synchronise kedro-starters branch with kedro version when the checkout argument is not provided and the constant is set to None.
In that case to release both kedro-starters and kedro we would need to:
Point to target kedro branch A in kedro-starters
Set up checkout constant in branch A for kedro, pointing to the corresponding branch in kedro-starters
Make sure all tests are passed for both repos
Point back to main branches for both repos
Release both
Possible Alternatives
The text was updated successfully, but these errors were encountered:
Description
In our current test setup starters & framework are linked and look to the "latest" version. At release time it leads to a situation where it's looking for the unreleased version and tests fail because of it.
Implement a way to fall back to the latest released version OR specify a specific version.
Context
"There's always cookiecutter" - @lrcouto
Currently
kedro-starters
points to mainkedro
branch: https://github.com/kedro-org/kedro-starters/blob/db79aec64c4a0f062321bd8c74ee782750bba527/test_requirements.txt#L5At the same time on
kedro
side we point to the mainkedro-starters
branch and synchronise it withkedro
version used:kedro/kedro/framework/cli/starters.py
Line 778 in 27f5405
kedro/tests/framework/cli/test_starters.py
Line 56 in 27f5405
As a result, when we need to release both
kedro-starters
andkedro
, we cannot specify a customkedro-starters
version on thekedro
side. So we have to make a release with failing tests and only after making sure that tests are passing at the CI.Possible Implementation
We already have a
checkout
argument that allows pointing to a specific tag or branch, which is used as an optional argument for thekedro new
command. We can add a constant to specify thecheckout
argument as we do for starters repo:kedro/kedro/framework/cli/starters.py
Line 98 in 27f5405
Then, in case the
checkout
argument was provided, it will be used instead of constant. For the rest of the cases, including testing, we will use the constant and we only synchronisekedro-starters
branch withkedro
version when thecheckout
argument is not provided and the constant is set toNone
.In that case to release both
kedro-starters
andkedro
we would need to:kedro
branchA
inkedro-starters
checkout
constant in branchA
forkedro
, pointing to the corresponding branch inkedro-starters
Possible Alternatives
The text was updated successfully, but these errors were encountered: