From 9ec96fbd0e9aff37630141154a96d3bcd745ee85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Mon, 26 Feb 2024 00:30:20 +0100 Subject: [PATCH 01/12] Rename ill-named CI check for docs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Juan Luis Cano Rodríguez --- .github/workflows/kedro-datasets.yml | 6 +++--- Makefile | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/kedro-datasets.yml b/.github/workflows/kedro-datasets.yml index f39fb37ca..fdaf53614 100644 --- a/.github/workflows/kedro-datasets.yml +++ b/.github/workflows/kedro-datasets.yml @@ -36,7 +36,7 @@ jobs: os: ubuntu-latest python-version: "3.11" - RTD-build: + check-docs: runs-on: ubuntu-latest steps: - name: Checkout code @@ -56,6 +56,6 @@ jobs: python -m pip install -U "pip>=21.2,<23.2" # Temporary fix cd kedro-datasets pip install ".[docs,test]" - - name: RTD build for kedro-datasets + - name: Documentation check for kedro-datasets run: | - make rtd + make plugin=kedro-datasets check-docs diff --git a/Makefile b/Makefile index 0ccf288a6..396ca6102 100644 --- a/Makefile +++ b/Makefile @@ -87,5 +87,5 @@ test-snowflake-only: cd kedro-datasets && pytest --no-cov --numprocesses 1 --dist loadfile -m snowflake cd kedro-datasets && pytest kedro_datasets/snowflake --doctest-modules --doctest-continue-on-failure --no-cov -rtd: - cd kedro-datasets && python -m sphinx -WETan -j auto -D language=en -b linkcheck -d _build/doctrees docs/source _build/linkcheck +check-docs: + cd $(plugin) && python -m sphinx -WETan -j auto -D language=en -b linkcheck -d _build/doctrees docs/source _build/linkcheck From 1235fb208fc0744dc3415868b47acc36da0993f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Mon, 26 Feb 2024 00:30:42 +0100 Subject: [PATCH 02/12] Use uv to accelerate dependency installation on CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Juan Luis Cano Rodríguez --- .github/workflows/e2e-tests.yml | 9 ++++++--- .github/workflows/kedro-datasets.yml | 6 ++++-- .github/workflows/lint.yml | 10 ++++++---- .github/workflows/unit-tests.yml | 11 ++++++----- 4 files changed, 22 insertions(+), 14 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 3c49d4e13..ee610a18d 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -29,13 +29,16 @@ jobs: path: ~/.cache/pip key: ${{inputs.plugin}}-${{inputs.os}}-python-${{inputs.python-version}} restore-keys: ${{inputs.plugin}} + - name: Install uv + run: | + python -m pip install "uv==0.1.11" - name: Install dependencies run: | cd ${{ inputs.plugin }} - pip install git+https://github.com/kedro-org/kedro@main - pip install ".[test]" + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro @ git+https://github.com/kedro-org/kedro@main" + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "${{inputs.plugin}}[test] @ ." - name: pip freeze - run: pip freeze + run: VIRTUAL_ENV=${Python_ROOT_DIR} uv pip freeze - name: Run end to end tests # Custom shell to run kedro-docker e2e-tests because -it flag for `docker run` # isn't supported on Github Actions. See https://github.com/actions/runner/issues/241 diff --git a/.github/workflows/kedro-datasets.yml b/.github/workflows/kedro-datasets.yml index fdaf53614..1c2f135b0 100644 --- a/.github/workflows/kedro-datasets.yml +++ b/.github/workflows/kedro-datasets.yml @@ -51,11 +51,13 @@ jobs: path: ~/.cache/pip key: kedro-datasets-ubuntu-latest-python-"3.9" restore-keys: kedro-datasets + - name: Install uv + run: | + python -m pip install "uv==0.1.11" - name: Install dependencies run: | - python -m pip install -U "pip>=21.2,<23.2" # Temporary fix cd kedro-datasets - pip install ".[docs,test]" + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro-datasets[docs,test] @ ." - name: Documentation check for kedro-datasets run: | make plugin=kedro-datasets check-docs diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 0499764b2..e39a6c5e2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -29,13 +29,15 @@ jobs: path: ~/.cache/pip key: ${{inputs.plugin}}-${{inputs.os}}-python-${{inputs.python-version}} restore-keys: ${{inputs.plugin}} + - name: Install uv + run: | + python -m pip install "uv==0.1.11" - name: Install dependencies run: | cd ${{ inputs.plugin }} - python -m pip install -U "pip>=21.2,<23.2" # Temporary fix - pip install git+https://github.com/kedro-org/kedro@main - pip install ".[test]" - pip freeze + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro @ git+https://github.com/kedro-org/kedro@main" + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "${{inputs.plugin}}[test] @ ." + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip freeze - name: Install pre-commit hooks run: | pre-commit install --install-hooks diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 6faaf6693..cb4e9962c 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -38,18 +38,19 @@ jobs: path: ~\AppData\Local\pip\Cache key: ${{inputs.plugin}}-${{inputs.os}}-python-${{inputs.python-version}} restore-keys: ${{inputs.plugin}} - - name: Install Kedro - run: pip install git+https://github.com/kedro-org/kedro@main - name: Add MSBuild to PATH if: inputs.os == 'windows-latest' uses: microsoft/setup-msbuild@v2 + - name: Install uv + run: | + python -m pip install "uv==0.1.11" - name: Install dependencies run: | cd ${{ inputs.plugin }} - python -m pip install -U "pip>=21.2,<23.2" # Temporary fix - pip install ".[test]" + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro @ git+https://github.com/kedro-org/kedro@main" + VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "${{inputs.plugin}}[test] @ ." - name: pip freeze - run: pip freeze + run: VIRTUAL_ENV=${Python_ROOT_DIR} uv pip freeze - name: Run unit tests for Linux / kedro-airflow, kedro-docker, kedro-telemetry if: inputs.os != 'windows-latest' && inputs.plugin != 'kedro-datasets' run: make plugin=${{ inputs.plugin }} test From 256d3c0b2133684f021ac67f8dbb7fb5336aa5f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Mon, 26 Feb 2024 17:53:22 +0100 Subject: [PATCH 03/12] Use smaller dataset for Hugging Face doctest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Juan Luis Cano Rodríguez --- .../huggingface/hugging_face_dataset.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py b/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py index 1976e45a5..b5554c9b8 100644 --- a/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py +++ b/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py @@ -24,11 +24,12 @@ class HFDataset(AbstractVersionedDataset): .. code-block:: pycon >>> from kedro_datasets.huggingface import HFDataset - >>> dataset = HFDataset(dataset_name="yelp_review_full") - >>> yelp_review_full = dataset.load() - >>> assert "train" in yelp_review_full - >>> assert "test" in yelp_review_full - >>> assert len(yelp_review_full["train"]) == 650000 + >>> dataset = HFDataset(dataset_name="openai_humaneval") + >>> ds = dataset.load() # doctest: +SKIP + ... + >>> ds = dataset.load() # second time there is no output (doctest workaround) + >>> assert "test" in ds + >>> assert len(ds["test"]) == 164 """ From 7789dc3434ac269b0b6edb8cb47b7a9d5616e857 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Mon, 26 Feb 2024 18:19:06 +0100 Subject: [PATCH 04/12] Fix pytest invokation on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/astral-sh/uv/issues/1988 Signed-off-by: Juan Luis Cano Rodríguez --- .github/workflows/unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index cb4e9962c..b2a8343c6 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -61,7 +61,7 @@ jobs: if: inputs.os == 'windows-latest' && inputs.plugin != 'kedro-datasets' run: | cd ${{ inputs.plugin }} - pytest tests + python -m pytest tests - name: Run unit tests for Windows / kedro-datasets / no spark parallel if: inputs.os == 'windows-latest' && inputs.plugin == 'kedro-datasets' run: | From 0f280ec5868916a81e774cce32ec5c2f429a79fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Mon, 26 Feb 2024 19:36:06 +0100 Subject: [PATCH 05/12] Definitive fix to Hugging Face doctest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Juan Luis Cano Rodríguez --- .../kedro_datasets/huggingface/hugging_face_dataset.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py b/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py index b5554c9b8..7489a78cf 100644 --- a/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py +++ b/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py @@ -23,11 +23,12 @@ class HFDataset(AbstractVersionedDataset): .. code-block:: pycon + >>> from datasets.utils.logging import disable_progress_bar, set_verbosity, ERROR + >>> disable_progress_bar() # for doctest to pass + >>> set_verbosity(ERROR) # for doctest to pass >>> from kedro_datasets.huggingface import HFDataset >>> dataset = HFDataset(dataset_name="openai_humaneval") - >>> ds = dataset.load() # doctest: +SKIP - ... - >>> ds = dataset.load() # second time there is no output (doctest workaround) + >>> ds = dataset.load() >>> assert "test" in ds >>> assert len(ds["test"]) == 164 From e7fe4396c23da220af667bfe3c951c2ae42b7cbb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Mon, 26 Feb 2024 19:57:58 +0100 Subject: [PATCH 06/12] Trigger CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Juan Luis Cano Rodríguez From 51a0f955d4fa6515890aa3a7ccca496781eebfc3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Mon, 26 Feb 2024 20:00:59 +0100 Subject: [PATCH 07/12] Debug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Juan Luis Cano Rodríguez --- .../kedro_datasets/huggingface/hugging_face_dataset.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py b/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py index 7489a78cf..9b9ab9325 100644 --- a/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py +++ b/kedro-datasets/kedro_datasets/huggingface/hugging_face_dataset.py @@ -28,7 +28,9 @@ class HFDataset(AbstractVersionedDataset): >>> set_verbosity(ERROR) # for doctest to pass >>> from kedro_datasets.huggingface import HFDataset >>> dataset = HFDataset(dataset_name="openai_humaneval") - >>> ds = dataset.load() + >>> ds = dataset.load() # doctest: +ELLIPSIS + Downloading and preparing dataset ... + Dataset ... >>> assert "test" in ds >>> assert len(ds["test"]) == 164 From b3de136e9bd676869eb63f35ed8a229c58354ce4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Wed, 28 Feb 2024 23:49:52 +0100 Subject: [PATCH 08/12] Bump to next uv version --- .github/workflows/e2e-tests.yml | 8 ++++---- .github/workflows/kedro-datasets.yml | 4 ++-- .github/workflows/lint.yml | 8 ++++---- .github/workflows/unit-tests.yml | 8 ++++---- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index ee610a18d..9f6bbf55c 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -31,14 +31,14 @@ jobs: restore-keys: ${{inputs.plugin}} - name: Install uv run: | - python -m pip install "uv==0.1.11" + python -m pip install "uv==0.1.12" - name: Install dependencies run: | cd ${{ inputs.plugin }} - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro @ git+https://github.com/kedro-org/kedro@main" - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "${{inputs.plugin}}[test] @ ." + uv pip install --system "kedro @ git+https://github.com/kedro-org/kedro@main" + uv pip install --system "${{inputs.plugin}}[test] @ ." - name: pip freeze - run: VIRTUAL_ENV=${Python_ROOT_DIR} uv pip freeze + run: uv pip freeze --system - name: Run end to end tests # Custom shell to run kedro-docker e2e-tests because -it flag for `docker run` # isn't supported on Github Actions. See https://github.com/actions/runner/issues/241 diff --git a/.github/workflows/kedro-datasets.yml b/.github/workflows/kedro-datasets.yml index 1c2f135b0..b09b300f0 100644 --- a/.github/workflows/kedro-datasets.yml +++ b/.github/workflows/kedro-datasets.yml @@ -53,11 +53,11 @@ jobs: restore-keys: kedro-datasets - name: Install uv run: | - python -m pip install "uv==0.1.11" + python -m pip install "uv==0.1.12" - name: Install dependencies run: | cd kedro-datasets - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro-datasets[docs,test] @ ." + uv pip install --system "kedro-datasets[docs,test] @ ." - name: Documentation check for kedro-datasets run: | make plugin=kedro-datasets check-docs diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index e39a6c5e2..7ceb03c54 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -31,13 +31,13 @@ jobs: restore-keys: ${{inputs.plugin}} - name: Install uv run: | - python -m pip install "uv==0.1.11" + python -m pip install "uv==0.1.12" - name: Install dependencies run: | cd ${{ inputs.plugin }} - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro @ git+https://github.com/kedro-org/kedro@main" - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "${{inputs.plugin}}[test] @ ." - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip freeze + uv pip install --system "kedro @ git+https://github.com/kedro-org/kedro@main" + uv pip install --system "${{inputs.plugin}}[test] @ ." + uv pip freeze --system - name: Install pre-commit hooks run: | pre-commit install --install-hooks diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index b2a8343c6..04079552b 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -43,14 +43,14 @@ jobs: uses: microsoft/setup-msbuild@v2 - name: Install uv run: | - python -m pip install "uv==0.1.11" + python -m pip install "uv==0.1.12" - name: Install dependencies run: | cd ${{ inputs.plugin }} - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "kedro @ git+https://github.com/kedro-org/kedro@main" - VIRTUAL_ENV=${Python_ROOT_DIR} uv pip install "${{inputs.plugin}}[test] @ ." + uv pip install --system "kedro @ git+https://github.com/kedro-org/kedro@main" + uv pip install --system "${{inputs.plugin}}[test] @ ." - name: pip freeze - run: VIRTUAL_ENV=${Python_ROOT_DIR} uv pip freeze + run: uv pip freeze --system - name: Run unit tests for Linux / kedro-airflow, kedro-docker, kedro-telemetry if: inputs.os != 'windows-latest' && inputs.plugin != 'kedro-datasets' run: make plugin=${{ inputs.plugin }} test From 7ee9bfecb19240fdeed30ea514eac57e8d5ff8c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Wed, 28 Feb 2024 23:53:49 +0100 Subject: [PATCH 09/12] Restore pytest invokation --- .github/workflows/unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 04079552b..51dca098c 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -61,7 +61,7 @@ jobs: if: inputs.os == 'windows-latest' && inputs.plugin != 'kedro-datasets' run: | cd ${{ inputs.plugin }} - python -m pytest tests + pytest tests - name: Run unit tests for Windows / kedro-datasets / no spark parallel if: inputs.os == 'windows-latest' && inputs.plugin == 'kedro-datasets' run: | From 43417bcb9e6cdb5fb8ba27af4250c4f1bb81458e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Thu, 29 Feb 2024 22:14:32 +0100 Subject: [PATCH 10/12] Upgrade to latest version of uv --- .github/workflows/e2e-tests.yml | 2 +- .github/workflows/kedro-datasets.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/unit-tests.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 9f6bbf55c..5e247a6b9 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -31,7 +31,7 @@ jobs: restore-keys: ${{inputs.plugin}} - name: Install uv run: | - python -m pip install "uv==0.1.12" + python -m pip install "uv==0.1.13" - name: Install dependencies run: | cd ${{ inputs.plugin }} diff --git a/.github/workflows/kedro-datasets.yml b/.github/workflows/kedro-datasets.yml index b09b300f0..18eff8a3e 100644 --- a/.github/workflows/kedro-datasets.yml +++ b/.github/workflows/kedro-datasets.yml @@ -53,7 +53,7 @@ jobs: restore-keys: kedro-datasets - name: Install uv run: | - python -m pip install "uv==0.1.12" + python -m pip install "uv==0.1.13" - name: Install dependencies run: | cd kedro-datasets diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 7ceb03c54..f50a34b2e 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -31,7 +31,7 @@ jobs: restore-keys: ${{inputs.plugin}} - name: Install uv run: | - python -m pip install "uv==0.1.12" + python -m pip install "uv==0.1.13" - name: Install dependencies run: | cd ${{ inputs.plugin }} diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 51dca098c..be5b859b1 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -43,7 +43,7 @@ jobs: uses: microsoft/setup-msbuild@v2 - name: Install uv run: | - python -m pip install "uv==0.1.12" + python -m pip install "uv==0.1.13" - name: Install dependencies run: | cd ${{ inputs.plugin }} From d7caf3841190680a3225d5bb436ddc1bb7d978d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Thu, 29 Feb 2024 22:18:53 +0100 Subject: [PATCH 11/12] Fix pyproject.toml --- kedro-datasets/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kedro-datasets/pyproject.toml b/kedro-datasets/pyproject.toml index f19c3baa5..1372378c4 100644 --- a/kedro-datasets/pyproject.toml +++ b/kedro-datasets/pyproject.toml @@ -56,7 +56,7 @@ matlab-matlabdataset = ["scipy"] matlab = ["kedro-datasets[matlab-matlabdataset]"] matplotlib-matplotlibwriter = ["matplotlib>=3.0.3, <4.0"] -matplotlib = ["kedro-datasets[]"] +matplotlib = ["kedro-datasets[matplotlib-matplotlibwriter]"] netcdf = ["kedro-datasets[netcdf-netcdfdataset]"] netcdf-netcdfdataset = ["h5netcdf>=1.2.0","netcdf4>=1.6.4","xarray>=2023.1.0"] From e8dc93e8be7b6bb3fc238c6b627560aeb3298fcc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Luis=20Cano=20Rodr=C3=ADguez?= Date: Fri, 1 Mar 2024 13:30:27 +0100 Subject: [PATCH 12/12] Make docs check plugin-specific MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Juan Luis Cano Rodríguez --- .github/workflows/kedro-datasets.yml | 2 +- Makefile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/kedro-datasets.yml b/.github/workflows/kedro-datasets.yml index 18eff8a3e..0f849ec5d 100644 --- a/.github/workflows/kedro-datasets.yml +++ b/.github/workflows/kedro-datasets.yml @@ -60,4 +60,4 @@ jobs: uv pip install --system "kedro-datasets[docs,test] @ ." - name: Documentation check for kedro-datasets run: | - make plugin=kedro-datasets check-docs + make check-datasets-docs diff --git a/Makefile b/Makefile index 396ca6102..15c696389 100644 --- a/Makefile +++ b/Makefile @@ -87,5 +87,5 @@ test-snowflake-only: cd kedro-datasets && pytest --no-cov --numprocesses 1 --dist loadfile -m snowflake cd kedro-datasets && pytest kedro_datasets/snowflake --doctest-modules --doctest-continue-on-failure --no-cov -check-docs: - cd $(plugin) && python -m sphinx -WETan -j auto -D language=en -b linkcheck -d _build/doctrees docs/source _build/linkcheck +check-datasets-docs: + cd kedro-datasets && python -m sphinx -WETan -j auto -D language=en -b linkcheck -d _build/doctrees docs/source _build/linkcheck