Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text glitche #2354

Merged
merged 3 commits into from
Jul 22, 2015
Merged

Fix text glitche #2354

merged 3 commits into from
Jul 22, 2015

Conversation

asturur
Copy link
Member

@asturur asturur commented Jul 21, 2015

What this commit do:

  • Resolve text decoration issue for some textAlign values
  • Remove a couple of canvas.save and canvas.restore couples
  • Solve a regression: when text is justified decoration and backgroundcolor are not.
  • do not justify text if a line contains just one word

@asturur
Copy link
Member Author

asturur commented Jul 22, 2015

@kangax ready to merge for me.
misc fixes nothing special, getLineWidth got more complicated but is necessary.

kangax added a commit that referenced this pull request Jul 22, 2015
@kangax kangax merged commit 2cedb1c into fabricjs:master Jul 22, 2015
@kangax
Copy link
Member

kangax commented Jul 22, 2015

Great, thanks! Just one minor thing in a comment: "I have to" -> "we have to" or "it has to be" coz it sounds strange otherwise

@asturur asturur deleted the fix-text-glitche branch July 22, 2015 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants