Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart security context rendering if empty #1235

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

botchk
Copy link
Contributor

@botchk botchk commented Aug 23, 2024

Closes #

📑 Description

When .Values.deployment.securityContext is empty ({}), the helm installation fails with

Error: YAML parse error on k8sgpt/templates/deployment.yaml: error converting YAML to JSON: yaml: lin
e 24: mapping values are not allowed in this context                                                 
                                                                                                     
Use --debug flag to render out invalid YAML 

This fixes the rendering.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Dominik Augustin <botchk@users.noreply.github.com>
@botchk botchk requested review from a team as code owners August 23, 2024 15:47
@arbreezy
Copy link
Member

arbreezy commented Sep 8, 2024

thanks @botchk

@AlexsJones AlexsJones merged commit be4ca86 into k8sgpt-ai:main Sep 9, 2024
7 of 8 checks passed
@botchk botchk deleted the fix/security-context-helm-chart branch September 9, 2024 07:50
AlexsJones pushed a commit that referenced this pull request Oct 24, 2024
Signed-off-by: Dominik Augustin <botchk@users.noreply.github.com>
Co-authored-by: Dominik Augustin <botchk@users.noreply.github.com>
Co-authored-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants