feat: catch events when analyze service #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicsong
force-pushed
the
add_service_event
branch
2 times, most recently
from
02e39ee to
06692c3
Compare
magicsong
changed the title
magicsong
force-pushed
the
add_service_event
branch
from
e61d660 to
fedc091
Compare
Signed-off-by: magicsong <songxuetao@bytedance.com>
magicsong
force-pushed
the
add_service_event
branch
from
fedc091 to
64164a0
Compare
AlexsJones
approved these changes
Jun 10, 2024
ronaldpetty
pushed a commit
to ronaldpetty/k8sgpt
that referenced
this pull request
Aug 17, 2024
Signed-off-by: magicsong <songxuetao@bytedance.com> Co-authored-by: magicsong <songxuetao@bytedance.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> Signed-off-by: Ronald Petty <ronald.petty@rx-m.com>
AlexsJones
added a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: magicsong <songxuetao@bytedance.com> Co-authored-by: magicsong <songxuetao@bytedance.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This pull request adds additional event information when analyzing the service. The enhancement ensures that specific events are captured and logged for better problem-finding
✅ Checks
ℹ Additional Information
No breaking changes have been introduced. This PR solely focuses on enhancing event logging during the analyze service process.