Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore TTL/priority of 0 #13

Closed
jungaretti opened this issue May 7, 2022 · 0 comments · Fixed by #14
Closed

Ignore TTL/priority of 0 #13

jungaretti opened this issue May 7, 2022 · 0 comments · Fixed by #14
Assignees
@jungaretti
Labels
bug Something isn't working

Comments

@jungaretti
Copy link
Owner

jungaretti commented May 7, 2022 •
edited
Loading

It makes sense to store TTL and priority values as numbers in config files, but this means we unmarshal a value of 0 when they aren't specified. We should treat 0, "0", and "" the same way when comparing records. We should only include a numerical value for TTL and priority in requests to Porkbun if their value is above 0.
@jungaretti jungaretti added the bug Something isn't working label May 7, 2022
@jungaretti jungaretti self-assigned this May 7, 2022
@jungaretti jungaretti mentioned this issue May 7, 2022
Merged
@jungaretti jungaretti added this to the v1.0 milestone May 8, 2022
@jungaretti jungaretti changed the title Broken comparisons between int and string types Ignore TTL and priority of 0 May 8, 2022
@jungaretti jungaretti changed the title Ignore TTL and priority of 0 Ignore TTL/priority of 0 May 8, 2022
@jungaretti jungaretti mentioned this issue May 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jungaretti jungaretti

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug when comparing "" and "0" TTL/priority jungaretti/bacon
1 participant
@jungaretti