Merge pull request #36 from jungaretti/jungaretti/remove-secrets-provider

Remove secrets package

Author: jungaretti

README.md

@@ -26,7 +26,9 @@ You can use Bacon locally or in a GitHub Actions workflow. For local use, downlo
 
 Sign into Porkbun and [generate a new API keyset](https://porkbun.com/account/api) for your account. Read the ["Generating API Keys" section of Porkbun's docs](https://kb.porkbun.com/article/190-getting-started-with-the-porkbun-dns-api) for more detailed instructions. Be sure to enable API access for the domain(s) that you would like to manage with Bacon.
 
-Next, export your `PORKBUN_API_KEY` and `PORKBUN_SECRET_KEY` as environment variables. You can also use a `.env` file in the current directory (see [`.env.example`](https://github.com/jungaretti/bacon/blob/main/.env.example) for an example).
+Next, `export` the `PORKBUN_API_KEY` and `PORKBUN_SECRET_KEY` environment variables or add them to an `.env` file. Bacon uses these environment variables to authenticate with Porkbun. If the current directory contains an `.env` file, then Bacon will load its contents into environment variables. See [`.env.example`](https://github.com/jungaretti/bacon/blob/main/.env.example) for an example.
+
+You can use [`bacon ping`](#ping) to check your authentication configuration.
 
 ## Usage
 

main.go

@@ -3,7 +3,7 @@ package main
 import (
 	"bacon/cmd"
 	"bacon/pkg/providers/porkbun"
-	"bacon/pkg/secrets"
+	"os"
 
 	"github.com/subosito/gotenv"
 )
@@ -12,9 +12,11 @@ func main() {
 	// Loads .env in the current directory
 	gotenv.Load()
 
-	// Only supports Porkbun... for now :D
+	var porkbunApiKey = os.Getenv("PORKBUN_API_KEY")
+	var porkbunSecretApiKey = os.Getenv("PORKBUN_SECRET_KEY")
+
 	app := cmd.App{
-		Provider: porkbun.NewPorkbunProvider(secrets.Provider{}),
+		Provider: porkbun.NewPorkbunProvider(porkbunApiKey, porkbunSecretApiKey),
 	}
 
 	cmd.Execute(&app)

pkg/providers/porkbun/porkbun.go

@@ -4,7 +4,6 @@ import (
 	"bacon/pkg/dns"
 	"bacon/pkg/providers/porkbun/api"
 	"bacon/pkg/providers/porkbun/record"
-	"bacon/pkg/secrets"
 	"fmt"
 )
 
@@ -62,12 +61,12 @@ func (p PorkProvider) DeleteRecord(domain string, toDelete dns.Record) error {
 	return p.Api.DeleteRecord(domain, target.Id)
 }
 
-func NewPorkbunProvider(secretsProvider secrets.Provider) dns.Provider {
+func NewPorkbunProvider(apiKey, secretApiKey string) dns.Provider {
 	return &PorkProvider{
 		Api: api.Api{
 			Auth: api.Auth{
-				ApiKey:       secretsProvider.Read(secrets.PorkbunApiKey),
-				SecretApiKey: secretsProvider.Read(secrets.PorkbunSecretKey),
+				ApiKey:       apiKey,
+				SecretApiKey: secretApiKey,
 			},
 		},
 	}