Improve code coverage

Author: phpnode

lib/rules/prop-types.js

@@ -91,12 +91,7 @@ module.exports = Components.detect(function(context, components, utils) {
         (tokens[1] && tokens[1].value === 'propTypes')
       ) {
         return true;
-      } else if (
-        node.typeAnnotation && (tokens[0].value === 'props' || (tokens[1] && tokens[1].value === 'props'))
-      ) {
-        return true;
       }
-
       return false;
     }
 
@@ -404,7 +399,7 @@ module.exports = Components.detect(function(context, components, utils) {
 
           unionTypeDefinition.children.push(type);
         }
-        if (unionTypeDefinition.length === 0) {
+        if (unionTypeDefinition.children.length === 0) {
           // no complex type found, simply accept everything
           return true;
         }

tests/lib/rules/prop-types.js

@@ -958,6 +958,69 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'type Person = {name: {firstname: string;}};',
+        'type Props = {people: Person[]|Person;};',
+        'class Hello extends React.Component {',
+        '  props: Props;',
+        '  render () {',
+        '    var names = [];',
+        '    if (Array.isArray(this.props.people)) {',
+        '      for (var i = 0; i < this.props.people.length; i++) {',
+        '        names.push(this.props.people[i].name.firstname);',
+        '      }',
+        '    } else {',
+        '      names.push(this.props.people.name.firstname);',
+        '    }',
+        '    return <div>Hello {names.join(', ')}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
+    }, {
+      code: [
+        'type Props = {ok: string | boolean;};',
+        'class Hello extends React.Component {',
+        '  props: Props;',
+        '  render () {',
+        '    return <div>Hello {this.props.ok}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
+    }, {
+      code: [
+        'type Props = {result: {ok: string | boolean;}|{ok: number | Array}};',
+        'class Hello extends React.Component {',
+        '  props: Props;',
+        '  render () {',
+        '    return <div>Hello {this.props.result.ok}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
+    }, {
+      code: [
+        'type Props = {result?: {ok?: ?string | boolean;}|{ok?: ?number | Array}};',
+        'class Hello extends React.Component {',
+        '  props: Props;',
+        '  render () {',
+        '    return <div>Hello {this.props.result.ok}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  props = {a: 123};',
+        '  render () {',
+        '    return <div>Hello</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],
 
@@ -1718,6 +1781,20 @@ ruleTester.run('prop-types', rule, {
       errors: [
         {message: '\'people[].name.lastname\' is missing in props validation'}
       ]
+    }, {
+      code: [
+        'type Props = {result?: {ok: string | boolean;}|{ok: number | Array}};',
+        'class Hello extends React.Component {',
+        '  props: Props;',
+        '  render () {',
+        '    return <div>Hello {this.props.result.notok}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      errors: [
+        {message: '\'result.notok\' is missing in props validation'}
+      ]
     }
   ]
 });