Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safari: survey-text submit causes page to refresh #610

Closed
jodeleeuw opened this issue Apr 15, 2019 · 3 comments
Closed

safari: survey-text submit causes page to refresh #610

jodeleeuw opened this issue Apr 15, 2019 · 3 comments
Labels
Milestone

Comments

@jodeleeuw
Copy link
Member

This is fixed by adding onsubmit="return false;" but I don't know if this has other consequences that need to be considered.

@jodeleeuw jodeleeuw added the bug label Apr 15, 2019
@jodeleeuw jodeleeuw added this to the 6.0.6 milestone Apr 15, 2019
@nabsul
Copy link
Contributor

nabsul commented May 8, 2019

I was able to reproduce this bug on Edge as well. Doesn't happen in Chrome.

@nabsul
Copy link
Contributor

nabsul commented May 8, 2019

The correct way to fix this is to add a call to event.preventDefault() in the submit function of survey-text.

I checked out other trials such as survey-multi-choice and they already have this in their code, so I think it was just missed by mistake.

@jodeleeuw It looks like they'll have this fixed in 6.0.6, but you can make the fix yourself as shown in the pull request that I've submitted.

@jodeleeuw
Copy link
Member Author

fixed in #613

@jodeleeuw jodeleeuw modified the milestones: 6.0.6, 6.1 May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants