Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools dark theme #4

Open
jccr opened this issue Oct 9, 2019 · 1 comment
Open

DevTools dark theme #4

jccr opened this issue Oct 9, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jccr
Copy link

jccr commented Oct 9, 2019

The result doesn't look as nice when using the dark theme of Chrome DevTools :(

Screenshot from 2019-10-08 19-54-42

Expected result:
Screenshot from 2019-10-08 19-57-35

(Works well in the default light theme though 👍 Thank you for making this!)

@viddo
Copy link
Collaborator

viddo commented Oct 9, 2019

Thanks for the report!
I don't recall if dark theme was a thing when I implemented it the first time.
Either way, I guess it's a matter of either changing the static colors defined in src/styles.js to some values that works well for both light and dark theme, or figure out how to identify and use different colors/variables per theming instead.

For anyone reading, feel free to send a PR! 🙏

@viddo viddo added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants