Skip to content

Commit

Permalink
Set buildid to empty string to gain reproducible builds
Browse files Browse the repository at this point in the history
  • Loading branch information
jrick committed Sep 5, 2019
1 parent 58fdecb commit dc96af5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/jrick/release

go 1.12
go 1.13

This comment has been minimized.

Copy link
@chappjc

chappjc Sep 5, 2019

Does this fix actually depend on this version line or was it all buildid?

This comment has been minimized.

Copy link
@jrick

jrick Sep 5, 2019

Author Owner

the build doesn't, but the tool assumes that -trimpath works.


require (
github.com/decred/dcrd v1.2.1-0.20190128173639-e3e8c47c68b0
Expand Down
4 changes: 2 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ var targets = []struct{ os, arch string }{
{"freebsd", "amd64"},
}

const dldflags = `-X github.com/decred/dcrd/internal/version.BuildMetadata=release ` +
const dldflags = `-buildid= -X github.com/decred/dcrd/internal/version.BuildMetadata=release ` +
`-X github.com/decred/dcrd/internal/version.PreRelease=`
const wldflags = `-X github.com/decred/dcrwallet/version.BuildMetadata=release ` +
const wldflags = `-buildid= -X github.com/decred/dcrwallet/version.BuildMetadata=release ` +
`-X github.com/decred/dcrwallet/version.PreRelease=`

const tags = "safe"
Expand Down

0 comments on commit dc96af5

Please sign in to comment.