-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart in dark mode #706
Comments
Thanks, I'll see if I can work out why the mermaid theme is not applying to these items. Out of interest, is there a reason you're opting to use the experimental charting features in mermaid instead of the existing chart.js library in the theme? |
I had some previous experience in PlantUML. When mermaid was added, I was just curious and wanted to give it a go. |
I've been able to narrow down where this issue arises for the pie charts. It's a bit of an oddity in how the mermaid theming works for these diagrams as it doesn't inherit all the styles from the base theme in the same way as the others. I've also taken another pass at how mermaid is being themed in Congo so that it better styles elements in dark mode. This should make all the diagrams look a little more consistent across the various modes. There are two caveats though:
If you want to try address the sankey issue in your project by overriding the CSS with a media query, the I'll push the other fixes shortly. |
Issue description
Problems
Dark mode for chart does not work as expected
Markdown snippet
Theme version
v2.7.4
Hugo version
hugo v0.120.4-f11bca5fec2ebb3a02727fb2a5cfb08da96fd9df+extended windows/amd64 BuildDate=2023-11-08T11:18:07Z VendorInfo=gohugoio
Which browser rendering engines are you seeing the problem on?
Chromium (Google Chrome, Microsoft Edge, Brave, Vivaldi, Opera, etc.)
URL to sample repository or website
https://jh123x.com/blog/2023/my-job-search/
Hugo output or build error messages
N/A
The text was updated successfully, but these errors were encountered: